Gitlab-169: Setup timeout fix #83
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempting to fix `setup.spec.ts` and `magentoAdmin.page.ts` by adding waitFor() and other optimizations.
- Added Github Actions activation on push to `setup-timeout-fix`. - Added report upload to setup test on fail.
- Changed operating system from `windows-latest` to `ubuntu-latest`
- Removed `--max-failures=1` from line 69 (Playwright test run command) to check if this is the cause of Github Actions failing
When `test-toggles.example.ts` is copied in the CI, this should be set to true
This commit updates the CI tests for `setup.spec.ts` to also contain the new test steps.
- Changed operating system back to Windows to check if Webkit test fails persist.
Changes from this commit: - Removed `.gitkeep` since the playwright-report folder isn't required. - Removed line from `.gitignore` to reflect above change. - Running `setup.spec.ts` will now check if the coupon codes have already been added. If coupon codes are found that are equal to the codes from `.env`, then a warning will be added to the report, but no error.
- Removed the line that invoked Github Actions on a push to the `setup-timeout-fix` branch
- Moved admin coupon field locator to element-identifiers.json - Removed code that was commented out.
Reverted mistake where I changed the Rule Name to the actual Coupon Code rather than naming it 'Test Coupon'
dheesen
requested changes
May 19, 2025
- Removed `*` from `/playwright-report/` to ensure entire folder + content is ignored.
- Readded ` --max-failures=1` to the `setup.spec.ts` command (line 56) to ensure testing suite does not continue after the setup failed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit mostly reworks
setup.spec.tsandmagentoAdmin.page.ts. An overview of the most important changes:setting up Magento environmenttest(group) insetup.spec.tshas now been broken down in clearer steps to show the user what is being done, making it easier to scan and fix errors when necessary.add Coupon Codesnow checks if the codes from.envcan already be found in the admin environment. If so, a notice will be pushed to the console as well as the report to notify the user. This ensures the setup will not fail if the coupon codes already exist.waitForLoadState("networkidle")since this is not according to best practices. Instead, we now use the appropriatewaitFor().evaluate()code where we select all stores when creating the coupon codes to explicitly note the element asHTMLSelectElementto ensure we don't get errors in our editors.