Fix/php84 forward compat - #26
Open
AndrewRMillar wants to merge 2 commits into
Open
Conversation
added 2 commits
August 4, 2026 11:40
- Helper\Data: drop unused callLogObj(); Zend\Log no longer exists since Magento 2.4 moved to Laminas, so it was a guaranteed fatal if ever called - Plugin\Import\Product: empty($ids) > 0 is always false, so the category reindex after a stock import never ran - Tests: setMethods() is removed in PHPUnit 10; split into onlyMethods() and addMethods() depending on whether the method exists on the mocked type. Add setUp(): void (fatal since PHPUnit 8) and declare $productMetadataMock instead of creating it dynamically
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove dead Zend logger, fix import reindex and modernise unit tests