Skip to content

Commit e3defdc

Browse files
author
Shay
committed
Merge branch '262-inconsistente-naamgeving-wijzig-productpage-naar-productpage-in-slugs-json' into 'main'
Resolve "Inconsistente naamgeving: wijzig 'productpage' naar 'productPage' in slugs.json" See merge request elgentos/magento2-playwright!41
2 parents 61d21ba + 3b16b16 commit e3defdc

File tree

12 files changed

+37
-37
lines changed

12 files changed

+37
-37
lines changed

‎tests/cart.spec.ts‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ test.describe('Cart functionalities (guest)', () => {
2323
*/
2424
test.beforeEach(async ({ page }, testInfo) => {
2525
const productPage = new ProductPage(page);
26-
await productPage.addSimpleProductToCart(UIReference.productPage.simpleProductTitle, slugs.productpage.simpleProductSlug);
26+
await productPage.addSimpleProductToCart(UIReference.productPage.simpleProductTitle, slugs.productPage.simpleProductSlug);
2727

2828
const productAddedNotification = `${outcomeMarker.productPage.simpleProductAddedNotification} ${UIReference.productPage.simpleProductTitle}`;
2929
const notificationValidator = new NotificationValidatorUtils(page, testInfo);
@@ -55,8 +55,8 @@ test.describe('Cart functionalities (guest)', () => {
5555
test('Product_remains_in_cart_after_login',{ tag: ['@cart', '@account', '@hot']}, async ({page, browserName}) => {
5656
await test.step('Add another product to cart', async () =>{
5757
const productpage = new ProductPage(page);
58-
await page.goto(slugs.productpage.secondSimpleProductSlug);
59-
await productpage.addSimpleProductToCart(UIReference.productPage.secondSimpleProducTitle, slugs.productpage.secondSimpleProductSlug);
58+
await page.goto(slugs.productPage.secondSimpleProductSlug);
59+
await productpage.addSimpleProductToCart(UIReference.productPage.secondSimpleProducTitle, slugs.productPage.secondSimpleProductSlug);
6060
});
6161

6262
await test.step('Log in with account', async () =>{
@@ -179,13 +179,13 @@ test.describe('Price checking tests', () => {
179179

180180
await test.step('Step: Add simple product to cart', async () =>{
181181
const productPage = new ProductPage(page);
182-
await page.goto(slugs.productpage.simpleProductSlug);
182+
await page.goto(slugs.productPage.simpleProductSlug);
183183
// set quantity to 2 so we can see that the math works
184184
await page.getByLabel(UIReference.productPage.quantityFieldLabel).fill('2');
185185

186186
productPagePrice = await page.locator(UIReference.productPage.simpleProductPrice).innerText();
187187
productPageAmount = await page.getByLabel(UIReference.productPage.quantityFieldLabel).inputValue();
188-
await productPage.addSimpleProductToCart(UIReference.productPage.simpleProductTitle, slugs.productpage.simpleProductSlug, '2');
188+
await productPage.addSimpleProductToCart(UIReference.productPage.simpleProductTitle, slugs.productPage.simpleProductSlug, '2');
189189

190190
});
191191

@@ -222,13 +222,13 @@ test.describe('Price checking tests', () => {
222222
await test.step('Step: Add configurable product to cart', async () =>{
223223
const productPage = new ProductPage(page);
224224
// Navigate to the configurable product page so we can retrieve price and amount before adding it to cart
225-
await page.goto(slugs.productpage.configurableProductSlug);
225+
await page.goto(slugs.productPage.configurableProductSlug);
226226
// set quantity to 2 so we can see that the math works
227227
await page.getByLabel('Quantity').fill('2');
228228

229229
productPagePrice = await page.locator(UIReference.productPage.simpleProductPrice).innerText();
230230
productPageAmount = await page.getByLabel(UIReference.productPage.quantityFieldLabel).inputValue();
231-
await productPage.addConfigurableProductToCart(UIReference.productPage.configurableProductTitle, slugs.productpage.configurableProductSlug, '2');
231+
await productPage.addConfigurableProductToCart(UIReference.productPage.configurableProductTitle, slugs.productPage.configurableProductSlug, '2');
232232

233233
});
234234

‎tests/checkout.spec.ts‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,8 @@ test.beforeEach(async ({ page }) => {
2727

2828
const productPage = new ProductPage(page);
2929

30-
await page.goto(slugs.productpage.simpleProductSlug);
31-
await productPage.addSimpleProductToCart(UIReference.productPage.simpleProductTitle, slugs.productpage.simpleProductSlug);
30+
await page.goto(slugs.productPage.simpleProductSlug);
31+
await productPage.addSimpleProductToCart(UIReference.productPage.simpleProductTitle, slugs.productPage.simpleProductSlug);
3232
await page.goto(slugs.checkout.checkoutSlug);
3333
});
3434

@@ -126,7 +126,7 @@ test.describe('Checkout (guest)', () => {
126126
const checkoutPage = new CheckoutPage(page);
127127

128128
// Add product to cart and go to checkout
129-
await productPage.addSimpleProductToCart(UIReference.productPage.simpleProductTitle, slugs.productpage.simpleProductSlug);
129+
await productPage.addSimpleProductToCart(UIReference.productPage.simpleProductTitle, slugs.productPage.simpleProductSlug);
130130
await page.goto(slugs.checkout.checkoutSlug);
131131

132132
// Select shipping method to trigger price calculations

‎tests/compare.spec.ts‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,12 @@ import { requireEnv } from '@utils/env.utils';
1212
test.beforeEach('Add 2 products to compare, then navigate to comparison page', async ({ page }) => {
1313
await test.step('Add products to compare', async () =>{
1414
const productPage = new ProductPage(page);
15-
await productPage.addProductToCompare(UIReference.productPage.simpleProductTitle, slugs.productpage.simpleProductSlug);
16-
await productPage.addProductToCompare(UIReference.productPage.secondSimpleProducTitle, slugs.productpage.secondSimpleProductSlug);
15+
await productPage.addProductToCompare(UIReference.productPage.simpleProductTitle, slugs.productPage.simpleProductSlug);
16+
await productPage.addProductToCompare(UIReference.productPage.secondSimpleProducTitle, slugs.productPage.secondSimpleProductSlug);
1717
});
1818

1919
await test.step('Navigate to product comparison page', async () =>{
20-
await page.goto(slugs.productpage.productComparisonSlug);
20+
await page.goto(slugs.productPage.productComparisonSlug);
2121
await expect(page.getByRole('heading', { name: UIReference.comparePage.comparisonPageTitleText }).locator('span')).toBeVisible();
2222
});
2323
});
@@ -69,11 +69,11 @@ test('Add_product_to_wishlist_from_comparison_page',{ tag: ['@comparison-page',
6969

7070
await loginPage.login(emailInputValue, passwordInputValue);
7171
});
72-
72+
7373
await test.step('Add product to compare', async () =>{
7474
const productPage = new ProductPage(page);
75-
await page.goto(slugs.productpage.productComparisonSlug);
76-
await productPage.addProductToCompare(UIReference.productPage.simpleProductTitle, slugs.productpage.simpleProductSlug);
75+
await page.goto(slugs.productPage.productComparisonSlug);
76+
await productPage.addProductToCompare(UIReference.productPage.simpleProductTitle, slugs.productPage.simpleProductSlug);
7777
});
7878

7979
await test.step('Add product to wishlist', async () =>{
@@ -88,10 +88,10 @@ test('Add_product_to_wishlist_from_comparison_page',{ tag: ['@comparison-page',
8888

8989
test.afterEach('Remove products from compare', async ({ page }) => {
9090
// ensure we are on the right page
91-
await page.goto(slugs.productpage.productComparisonSlug);
91+
await page.goto(slugs.productPage.productComparisonSlug);
9292

9393
page.on('dialog', dialog => dialog.accept());
9494
const comparePage = new ComparePage(page);
9595
await comparePage.removeProductFromCompare(UIReference.productPage.simpleProductTitle);
9696
await comparePage.removeProductFromCompare(UIReference.productPage.secondSimpleProducTitle);
97-
});
97+
});

‎tests/config/slugs.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
"contact": {
2525
"contactSlug": "/contact"
2626
},
27-
"productpage": {
27+
"productPage": {
2828
"configurableProductSlug": "/inez-full-zip-jacket.html",
2929
"productComparisonSlug": "/catalog/product_compare/index/",
3030
"secondSimpleProductSlug": "/aim-analog-watch.html",

‎tests/healthcheck.spec.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,8 @@ test.describe('Page health checks', () => {
3434
});
3535

3636
test('Pdp_returns_200', { tag: ['@smoke', '@cold'] }, async ({page}) => {
37-
const pdpResponsePromise = page.waitForResponse(slugs.productpage.simpleProductSlug);
38-
await page.goto(slugs.productpage.simpleProductSlug);
37+
const pdpResponsePromise = page.waitForResponse(slugs.productPage.simpleProductSlug);
38+
await page.goto(slugs.productPage.simpleProductSlug);
3939
const pdpResponse = await pdpResponsePromise;
4040
expect(pdpResponse.status(), 'PDP should return 200').toBe(200);
4141

‎tests/mainmenu.spec.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,6 @@ test('Open_the_minicart', { tag: ['@mainmenu', '@cold'] }, async ({page}, testIn
4646
const mainMenu = new MainMenuPage(page);
4747
const productPage = new ProductPage(page);
4848

49-
await productPage.addSimpleProductToCart(UIReference.productPage.simpleProductTitle, slugs.productpage.simpleProductSlug);
49+
await productPage.addSimpleProductToCart(UIReference.productPage.simpleProductTitle, slugs.productPage.simpleProductSlug);
5050
await mainMenu.openMiniCart();
5151
});

‎tests/minicart.spec.ts‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import ProductPage from '@poms/frontend/product.page';
88
import MiniCartPage from '@poms/frontend/minicart.page';
99

1010
test.describe('Minicart Actions', {annotation: {type: 'Minicart', description: 'Minicart simple product tests'},}, () => {
11-
11+
1212
/**
1313
* @feature BeforeEach runs before each test in this group.
1414
* @scenario Add a product to the cart and confirm it's there.
@@ -24,8 +24,8 @@ test.describe('Minicart Actions', {annotation: {type: 'Minicart', description: '
2424
const mainMenu = new MainMenuPage(page);
2525
const productPage = new ProductPage(page);
2626

27-
await page.goto(slugs.productpage.simpleProductSlug);
28-
await productPage.addSimpleProductToCart(UIReference.productPage.simpleProductTitle, slugs.productpage.simpleProductSlug);
27+
await page.goto(slugs.productPage.simpleProductSlug);
28+
await productPage.addSimpleProductToCart(UIReference.productPage.simpleProductTitle, slugs.productPage.simpleProductSlug);
2929
await mainMenu.openMiniCart();
3030
await expect(page.getByText(outcomeMarker.miniCart.simpleProductInCartTitle)).toBeVisible();
3131
});
@@ -114,8 +114,8 @@ test.describe('Minicart Actions', {annotation: {type: 'Minicart', description: '
114114
const mainMenu = new MainMenuPage(page);
115115
const productPage = new ProductPage(page);
116116

117-
await page.goto(slugs.productpage.configurableProductSlug);
118-
await productPage.addConfigurableProductToCart(UIReference.productPage.configurableProductTitle, slugs.productpage.configurableProductSlug, '2');
117+
await page.goto(slugs.productPage.configurableProductSlug);
118+
await productPage.addConfigurableProductToCart(UIReference.productPage.configurableProductTitle, slugs.productPage.configurableProductSlug, '2');
119119
await mainMenu.openMiniCart();
120120
await expect(page.getByText(outcomeMarker.miniCart.configurableProductMinicartTitle)).toBeVisible();
121121
});

‎tests/orderhistory.spec.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@ test('Recent_order_is_visible_in_history', async ({ page, browserName }) => {
2121

2222
await loginPage.login(emailInputValue, passwordInputValue);
2323

24-
await page.goto(slugs.productpage.simpleProductSlug);
25-
await productPage.addSimpleProductToCart(UIReference.productPage.simpleProductTitle, slugs.productpage.simpleProductSlug);
24+
await page.goto(slugs.productPage.simpleProductSlug);
25+
await productPage.addSimpleProductToCart(UIReference.productPage.simpleProductTitle, slugs.productPage.simpleProductSlug);
2626
await page.goto(slugs.checkout.checkoutSlug);
2727
const orderNumberLocator = await checkoutPage.placeOrder();
2828
const orderNumberText = await orderNumberLocator.innerText();

‎tests/poms/frontend/mainmenu.page.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ class MainMenuPage {
2121
}
2222

2323
async gotoMyAccount(){
24-
await this.page.goto(slugs.productpage.simpleProductSlug);
24+
await this.page.goto(slugs.productPage.simpleProductSlug);
2525
await this.mainMenuAccountButton.click();
2626
await this.mainMenuMyAccountItem.click();
2727

‎tests/poms/frontend/product.page.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ class ProductPage {
3131
await successMessage.waitFor();
3232
await expect(this.page.getByText(productAddedNotification)).toBeVisible();
3333

34-
await this.page.goto(slugs.productpage.productComparisonSlug);
34+
await this.page.goto(slugs.productPage.productComparisonSlug);
3535

3636
// Assertion: a cell with the product name inside a cell with the product name should be visible
3737
await expect(this.page.getByRole('cell', {name: product}).getByText(product, {exact: true})).toBeVisible();

0 commit comments

Comments
 (0)