Skip to content

Conversation

@shayfaber
Copy link
Collaborator

Changes

  • Most tests now have an additional check to ensure the desired outcome has actually been reached (or not!)
  • expects that asses if a notification is shown are now so called soft expects: the test will continue but mark the test. This is to ensure the additional check can still run.
  • Known issue for Firefox: The minicart button in the menu does not lose the "aria-disabled=true" flag when the first product is added to the cart, even after reload() and waitFor(). This prevents Playwright from opening the minicart and therefore continuing the test. Only consistently happens in UI mode, only when the first product gets added. Sometimes succeeds and sometimes fails when run from the terminal.

@shayfaber shayfaber requested a review from dheesen February 5, 2025 08:14
Copy link
Collaborator

@dheesen dheesen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shayfaber Tiny remark of, I think, missed soft expect.

@shayfaber shayfaber requested a review from dheesen February 5, 2025 09:13
@dheesen dheesen merged commit 3fe1694 into main Feb 5, 2025
1 check passed
@dheesen dheesen deleted the gitlab-110 branch February 5, 2025 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants