Skip to content

#17 Check if Set-Cookie headers are removed for cacheable content #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 26, 2025

Conversation

toonvd
Copy link
Collaborator

@toonvd toonvd commented May 25, 2025

@ThijsFeryn I have abused bgfetch from softpurging for this, Is there any other way?

@toonvd toonvd changed the title #17: Check if Set-Cookie headers are removed for cacheable content #17 Check if Set-Cookie headers are removed for cacheable content May 25, 2025
@ThijsFeryn ThijsFeryn self-requested a review May 26, 2025 08:50
@ThijsFeryn
Copy link
Collaborator

@toonvd I simplified the logic a bit by removing the soft purge logic.:

  • We don't need cache tags
  • We need a valid Cache-Control header with a positive TTL
  • We can do an initial client request (that is a cache miss) to check the Set-Cookie header
  • We can do a second client request (that is a cache hit) to check the Set-Cookie header
  • We can monitor the BerespUnset "Set-Cookie: testcookie=1; path=/; HttpOnly" tag in the logs through logexpect

@ThijsFeryn
Copy link
Collaborator

@toonvd I also added a HEAD request test.

Can you run this test again. If it succeeds & you agree with the logic I used, go ahead & merge.

@ThijsFeryn ThijsFeryn mentioned this pull request May 26, 2025
30 tasks
@peterjaap peterjaap merged commit 8b358f2 into master May 26, 2025
7 checks passed
@ThijsFeryn ThijsFeryn deleted the set_cookie_remove branch May 26, 2025 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants