Skip to content

#17 makes graphql conform to default Magento and creates tests #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 27, 2025

Conversation

toonvd
Copy link
Collaborator

@toonvd toonvd commented May 25, 2025

This:

  • makes us conform default Magento VCL for graphql
  • tests graphql
  • makes Docker containers cacheable

@toonvd toonvd requested a review from ThijsFeryn May 25, 2025 15:49
@peterjaap
Copy link
Contributor

@toonvd what was the logic behind this again?

@ThijsFeryn
Copy link
Collaborator

@toonvd this test already looks very good. There are a couple of cases that still need to be tested:

  • Test cache variations for different values of X-Magento-Cache-Id (check for hits & misses on the same GraphQL endpoint with different cache ids)
  • Test cache variations with the use of X-Magento-Cache-Id but with different Store & Content-Currency headers

@ThijsFeryn ThijsFeryn mentioned this pull request May 26, 2025
30 tasks
@toonvd
Copy link
Collaborator Author

toonvd commented May 26, 2025

@ThijsFeryn I added more coverage. As requested. I numbered the server reqs also because when the tests get larger I tend to lose count. Any ideas on other things that might help? Do know that other people aside from us need to write tests to get their PRs passed. We need to make this as bearable as possible.

@ThijsFeryn
Copy link
Collaborator

@toonvd It's perfectly fine to have multiple VTC files to split up the logic

@toonvd
Copy link
Collaborator Author

toonvd commented May 27, 2025

Check, I think it's fine like this for this test. If you agree please approve and merge.

@ThijsFeryn
Copy link
Collaborator

@toonvd I added some more test cases to check for hits after misses. I also added some header expectations at the server level to catch potential issues quicker.

I'll approve the PR, but please verify my changes and merge the PR if you agree with them.

@toonvd toonvd merged commit 6ae9d24 into master May 27, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants