Conversation
elgopher
force-pushed
the
piebiten-refactor
branch
3 times, most recently
from
1eec07a to
f501695
Compare
elgopher
changed the title
elgopher
force-pushed
the
piebiten-refactor
branch
2 times, most recently
from
712c7c9 to
5771637
Compare
Using a buffered channel could lead to a situation when a game will schedule audio in the past.
Pi works correctly with both SingleThread=true and SingleThread=false. However, to ensure that no future changes introduce concurrency bugs, it's better to default to SingleThread=false. This setting enforces proper synchronization in Pi, for example in the audio player.
coroutine.go is not a proper name and it was a typo.
To avoid confusion with *Sample rate, which is max 48000.
elgopher
force-pushed
the
piebiten-refactor
branch
from
5771637 to
9257035
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor piebiten internals