Login #13
Login #13
Conversation
| import fetchAsync from '../utils/fetch'; | ||
| import createExpiresCookie from '../utils/create-expires-cookie'; | ||
|
|
||
| const cookie = require('isomorphic-cookie'); |
There was a problem hiding this comment.
https://thumbs.gfycat.com/SmoggyHilariousBaiji-poster.jpg
Use import please
|
|
||
| const cookie = require('isomorphic-cookie'); | ||
|
|
||
| const minutesOfCookieLive = 60; |
There was a problem hiding this comment.
Good approach to naming, but better English would be: minutesCookiesLive
| }; | ||
| } | ||
| export function loginSuccess(data) { | ||
| cookie.save('token', data.data.token, { |
There was a problem hiding this comment.
please use lodash/get for data.data.token so your code doesn't break when your server fails
| }; | ||
| } | ||
| export function alertCreator(text) { | ||
| const millisecondsToAlertDisapear = 3000; |
There was a problem hiding this comment.
Hm, better move this constant one level out
| dispatch(loginStart()); | ||
| try { | ||
| const payload = await fetchAsync(`${apiURL}/login`, 'POST', loginValue); | ||
| if (!payload.data) { |
There was a problem hiding this comment.
I'd expect you to check HTTP response status code... If you provide any on error
| }; | ||
| } | ||
| export function registrationSuccess(data) { | ||
| cookie.save('token', data.data.token, { |
There was a problem hiding this comment.
please use lodash/get for data.data.token so your code doesn't break when your server fails
| }; | ||
| } | ||
|
|
||
| export function registration(regitrationValue) { |
| }; | ||
|
|
||
| function Login() { | ||
| const formLoginState = useSelector(state => state.form.Login); |
There was a problem hiding this comment.
what if your form is suddenly null? Write useSelector(property('form.Login))` to avoid
| @@ -0,0 +1,7 @@ | |||
| export default function createExpiresCookie(minutes) { | |||
| const millisecondsInSeconds = 1000; | |||
| const secondsInMinutes = 60; | |||
There was a problem hiding this comment.
Move these constants out
No description provided.