Convert NumbersViewModel to Kotlin

[tuancoltech]

Convert NumbersViewModel to Kotlin

Summary by CodeRabbit

• Refactor
  • Migrated the NumbersViewModel from Java to Kotlin for improved maintainability.
  • Updated NumbersFragment to use the new Kotlin-based NumbersViewModel.
• Chores
  • Removed the obsolete Java implementation of NumbersViewModel.

[coderabbitai]

Walkthrough

This change migrates the NumbersViewModel from Java to Kotlin within the ai.elimu.content_provider.ui.number package. The new Kotlin implementation preserves the original logic: it maintains a LiveData<String> holding a static string and exposes it via a getter method. The NumbersFragment is updated to observe this LiveData through the new getter method. No additional features or logic are introduced; the refactor focuses on language migration and minor API usage adjustments. All changes align with elimu.ai's mission to build innovative learning software that empowers out-of-school children to teach themselves basic reading📖, writing✍🏽 and math🔢 within 6 months.

Changes

File(s)	Change Summary
app/src/main/java/ai/elimu/content_provider/ui/number/NumbersViewModel.java	Deleted the Java implementation of NumbersViewModel, which provided a static LiveData string.
app/src/main/java/ai/elimu/content_provider/ui/number/NumbersViewModel.kt	Added a Kotlin implementation of NumbersViewModel with equivalent LiveData logic and getter method.
app/src/main/java/ai/elimu/content_provider/ui/number/NumbersFragment.kt	Updated to observe LiveData via the new Kotlin getter method (getText()).

Sequence Diagram(s)

sequenceDiagram
    participant Fragment as NumbersFragment
    participant ViewModel as NumbersViewModel (Kotlin)
    participant LiveData

    Fragment->>ViewModel: getText()
    ViewModel->>LiveData: Return LiveData<String> ("NumbersViewModel")
    Fragment->>LiveData: observe(observer)
    LiveData-->>Fragment: onChanged("NumbersViewModel")
    Fragment->>Fragment: Update textNumbers TextView

Loading

Possibly related PRs

• Convert SoundsViewModel to Kotlin #249: Converts a ViewModel class from Java to Kotlin and updates the corresponding Fragment to observe LiveData via a getter, mirroring this refactor pattern.
• Convert LettersFragment from Java to Kotlin #170: Performs a similar Java-to-Kotlin conversion for LettersFragment and its ViewModel, involving analogous refactoring.
• Convert NumbersFragment, NumbersViewModel to Kotlin #250: Converts NumbersFragment and NumbersViewModel from Java to Kotlin, including LiveData access changes, directly relating to the current migration.

Suggested reviewers

• jo-elimu

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2ed6ce7 and a864261.

📒 Files selected for processing (3)

• app/src/main/java/ai/elimu/content_provider/ui/number/NumbersFragment.kt (1 hunks)
• app/src/main/java/ai/elimu/content_provider/ui/number/NumbersViewModel.java (0 hunks)
• app/src/main/java/ai/elimu/content_provider/ui/number/NumbersViewModel.kt (1 hunks)

💤 Files with no reviewable changes (1)

• app/src/main/java/ai/elimu/content_provider/ui/number/NumbersViewModel.java

⏰ Context from checks skipped due to timeout of 90000ms (8)

• GitHub Check: build (macos-latest, 21)
• GitHub Check: build (windows-latest, 21)
• GitHub Check: build (windows-latest, 17)
• GitHub Check: build (ubuntu-latest, 17)
• GitHub Check: build (ubuntu-latest, 21)
• GitHub Check: build (macos-latest, 17)
• GitHub Check: test (28)
• GitHub Check: test (29)

🔇 Additional comments (2)

app/src/main/java/ai/elimu/content_provider/ui/number/NumbersViewModel.kt (1)

1-17: Excellent migration to Kotlin!

The conversion from Java to Kotlin is well-implemented with proper Kotlin idioms. The code correctly:

• Uses property syntax with val for immutability
• Properly initializes LiveData in the init block
• Maintains encapsulation by keeping the MutableLiveData private
• Exposes an immutable LiveData through the getter method

This clean implementation helps support elimu.ai's mission to build innovative learning software that empowers out-of-school children to teach themselves basic reading📖, writing✍🏽 and math🔢 within 6 months.

app/src/main/java/ai/elimu/content_provider/ui/number/NumbersFragment.kt (1)

39-39: Correctly updated to use the new getter method

The code now properly uses getText() instead of directly accessing the property, which aligns with the encapsulation provided by the Kotlin implementation of NumbersViewModel.

This careful attention to proper encapsulation practices contributes to code maintainability, which is essential as elimu.ai works toward its mission to build innovative learning software that empowers out-of-school children to teach themselves basic reading📖, writing✍🏽 and math🔢 within 6 months.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.