Skip to content

Fix Lint warnings in LetterSoundsFragment #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tuancoltech merged 6 commits into from
Apr 20, 2025
Merged

Fix Lint warnings in LetterSoundsFragment #252

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ba57f97
Replace findViewById with viewBinding
tuancoltech Apr 20, 2025
e8b5ae2
Remove unnecessary non-null assertions
tuancoltech Apr 20, 2025
418d3b5
Replace String concatenation with string resource
tuancoltech Apr 20, 2025
e4d53a0
Use isNotEmpty() for size check
tuancoltech Apr 20, 2025
7988d7c
Enhance variable naming
tuancoltech Apr 20, 2025
cf14cc7
Replace anonymous class with lambda
tuancoltech Apr 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 13 additions & 18 deletions app/src/main/java/ai/elimu/content_provider/ui/letter_sound/LetterSoundsFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package ai.elimu.content_provider.ui.letter_sound

import ai.elimu.content_provider.BaseApplication
import ai.elimu.content_provider.R
import ai.elimu.content_provider.databinding.FragmentLetterSoundsBinding
import ai.elimu.content_provider.rest.LetterSoundsService
import ai.elimu.content_provider.room.GsonToRoomConverter
import ai.elimu.content_provider.room.db.RoomDb
Expand All @@ -13,8 +14,6 @@ import android.util.Log
import android.view.LayoutInflater
import android.view.View
import android.view.ViewGroup
import android.widget.ProgressBar
import android.widget.TextView
import androidx.fragment.app.Fragment
import androidx.lifecycle.ViewModelProvider
import com.google.android.material.snackbar.Snackbar
Expand All @@ -24,11 +23,9 @@ import retrofit2.Response
import java.util.concurrent.Executors

class LetterSoundsFragment : Fragment() {
private var letterSoundsViewModel: LetterSoundsViewModel? = null

private var progressBar: ProgressBar? = null

private var textView: TextView? = null
private var letterSoundsViewModel: LetterSoundsViewModel? = null
private lateinit var binding: FragmentLetterSoundsBinding

private val TAG = javaClass.name

Expand All @@ -40,14 +37,12 @@ class LetterSoundsFragment : Fragment() {
Log.i(TAG, "onCreateView")

letterSoundsViewModel = ViewModelProvider(this)[LetterSoundsViewModel::class.java]
val root = inflater.inflate(R.layout.fragment_letter_sounds, container, false)
progressBar = root.findViewById(R.id.progress_bar_letter_sounds)
textView = root.findViewById(R.id.text_letter_sounds) as? TextView
binding = FragmentLetterSoundsBinding.inflate(layoutInflater)
letterSoundsViewModel?.text?.observe(viewLifecycleOwner) { s ->
Log.i(TAG, "onChanged")
textView?.text = s
binding.textLetterSounds.text = s
}
return root
return binding.root
Comment on lines +40 to +45
Copy link
Copy Markdown

@coderabbitai coderabbitai bot Apr 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Refine binding inflation for correct attachment and lifecycle.
Use the passed inflater and container when inflating to respect theme and layout parameters.

Apply this diff:

-        binding = FragmentLetterSoundsBinding.inflate(layoutInflater)
+        _binding = FragmentLetterSoundsBinding.inflate(inflater, container, false)
         letterSoundsViewModel?.text?.observe(viewLifecycleOwner) { s ->
             Log.i(TAG, "onChanged")
             binding.textLetterSounds.text = s
         }
-        return binding.root
+        return binding.root

Committable suggestion skipped: line range outside the PR's diff.

}

override fun onStart() {
Expand Down Expand Up @@ -79,10 +74,10 @@ class LetterSoundsFragment : Fragment() {
}
} else {
// Handle error
Snackbar.make(textView!!, response.toString(), Snackbar.LENGTH_LONG)
Snackbar.make(binding.textLetterSounds, response.toString(), Snackbar.LENGTH_LONG)
.setBackgroundTint(resources.getColor(R.color.deep_orange_darken_4))
.show()
progressBar!!.visibility = View.GONE
binding.progressBarLetterSounds.visibility = View.GONE
}
}

Expand All @@ -92,10 +87,10 @@ class LetterSoundsFragment : Fragment() {
Log.e(TAG, "t.getCause():", t.cause)

// Handle error
Snackbar.make(textView!!, t.cause.toString(), Snackbar.LENGTH_LONG)
Snackbar.make(binding.textLetterSounds, t.cause.toString(), Snackbar.LENGTH_LONG)
.setBackgroundTint(resources.getColor(R.color.deep_orange_darken_4))
.show()
progressBar!!.visibility = View.GONE
binding.progressBarLetterSounds.visibility = View.GONE
}
})
}
Expand Down Expand Up @@ -168,13 +163,13 @@ class LetterSoundsFragment : Fragment() {
val letterSounds = letterSoundDao.loadAll()
Log.i(TAG, "letterSounds.size(): " + letterSounds.size)
activity!!.runOnUiThread {
textView!!.text = "letterSounds.size(): " + letterSounds.size
binding.textLetterSounds.text = "letterSounds.size(): " + letterSounds.size
Snackbar.make(
textView!!,
binding.textLetterSounds,
"letterSounds.size(): " + letterSounds.size,
Snackbar.LENGTH_LONG
).show()
progressBar!!.visibility = View.GONE
binding.progressBarLetterSounds.visibility = View.GONE
}
}
})
Expand Down
Loading