Skip to content

Update compile/target SDK version to 35#35

Merged
tuancoltech merged 1 commit intomainfrom
build/upgrade_gradle_build_tools_8.5
Feb 21, 2025
Merged

Update compile/target SDK version to 35#35
tuancoltech merged 1 commit intomainfrom
build/upgrade_gradle_build_tools_8.5

Conversation

@tuancoltech
Copy link
Copy Markdown
Member

* Upgrade compileSdk to 35
* Add Java 21 to Github action build script
@tuancoltech tuancoltech requested a review from jo-elimu February 21, 2025 08:14
@tuancoltech tuancoltech self-assigned this Feb 21, 2025
@tuancoltech tuancoltech requested a review from a team as a code owner February 21, 2025 08:14
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Feb 21, 2025

Walkthrough

The pull request updates the Android project's build configuration. In the application module, the SDK versions have been increased from 33 to 35. In the project-level configuration, the Android Gradle plugin dependency has been upgraded from version 8.0.2 to 8.5.2. These changes ensure that the project builds with newer SDK features and tooling.

Changes

File(s) Change Summary
app/build.gradle Updated compileSdk and targetSdkVersion from 33 to 35
build.gradle Updated Android Gradle plugin dependency from 8.0.2 to 8.5.2

Suggested Reviewers

  • jo-elimu

Poem

I’m a hopping rabbit in the code garden fine,
With new SDKs and Gradle tools, my steps align.
Versions leap like carrots bright in bloom,
Build success sings away any gloom.
Celebrating these changes, I cheer with delight! 🐇
CodeRabbit's magic makes our path shine bright!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 90b6304 and b5b2aaf.

⛔ Files ignored due to path filters (1)
  • .github/workflows/gradle.yml is excluded by !**/*.yml
📒 Files selected for processing (2)
  • app/build.gradle (1 hunks)
  • build.gradle (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (6)
  • GitHub Check: build (windows-latest, 21)
  • GitHub Check: build (windows-latest, 17)
  • GitHub Check: build (macos-latest, 21)
  • GitHub Check: build (macos-latest, 17)
  • GitHub Check: build (ubuntu-latest, 21)
  • GitHub Check: build (ubuntu-latest, 17)
🔇 Additional comments (3)
build.gradle (1)

12-12: Android Gradle Plugin Version Update
The dependency has been updated to use version 8.5.2, which aligns with the objective to upgrade to the latest Android Gradle Plugin and build tools. Ensure that all modules and plugins are compatible with this newer version.

app/build.gradle (2)

10-10: Update compileSdk Version
The compileSdk version is now set to 35, which ensures the app is compiled against the latest Android SDK. Double-check any usage of new APIs to ensure proper handling.


15-15: Update targetSdkVersion
The targetSdkVersion has been updated to 35. This adjustment is important for runtime compliance with the latest Android behaviors. Please verify that any API changes or deprecations in SDK 35 are appropriately managed.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.55%. Comparing base (90b6304) to head (b5b2aaf).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main      #35   +/-   ##
=========================================
  Coverage     11.55%   11.55%           
  Complexity        9        9           
=========================================
  Files            10       10           
  Lines           199      199           
  Branches         37       37           
=========================================
  Hits             23       23           
  Misses          175      175           
  Partials          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tuancoltech tuancoltech merged commit 858f808 into main Feb 21, 2025
8 checks passed
@tuancoltech tuancoltech deleted the build/upgrade_gradle_build_tools_8.5 branch February 21, 2025 08:33
This was referenced Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done ☑️

Development

Successfully merging this pull request may close these issues.

2 participants