Open
Conversation
tomaszsmy
requested review from
jpatel3,
nya-elimu and
shiv810
and removed request for
a team
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1583 +/- ##
============================================
+ Coverage 13.78% 13.96% +0.18%
- Complexity 454 459 +5
============================================
Files 257 257
Lines 8503 8512 +9
Branches 881 884 +3
============================================
+ Hits 1172 1189 +17
+ Misses 7279 7271 -8
Partials 52 52 ☔ View full report in Codecov by Sentry. |
nya-elimu
requested changes
Jul 19, 2022
src/main/java/ai/elimu/web/content/word/WordCreateController.java
Outdated
Show resolved
Hide resolved
nya-elimu
reviewed
Jul 22, 2022
nya-elimu
requested changes
Jul 22, 2022
Member
nya-elimu
left a comment
nya-elimu
left a comment
There was a problem hiding this comment.
The application crashes when I try to submit an empty word:
Caused by: java.lang.NullPointerException
at ai.elimu.web.content.word.WordCreateController.validateWord (WordCreateController.java:280)
at ai.elimu.web.content.word.WordCreateController.handleSubmit (WordCreateController.java:116)
nya-elimu
requested changes
Jul 24, 2022
Member
nya-elimu
left a comment
nya-elimu
left a comment
There was a problem hiding this comment.
Added a suggestion to change how the validation works.
src/test/java/ai/elimu/web/content/word/WordCreateControllerTest.java
Outdated
Show resolved
Hide resolved
nya-elimu
requested changes
Jul 25, 2022
Member
nya-elimu
left a comment
nya-elimu
left a comment
There was a problem hiding this comment.
"10th" should be accepted as a word.
src/test/java/ai/elimu/web/content/word/WordCreateControllerTest.java
Outdated
Show resolved
Hide resolved
# Conflicts: # src/main/java/ai/elimu/web/content/word/WordCreateController.java # src/test/java/ai/elimu/web/content/word/WordCreateControllerTest.java
…ds_that_are_digits
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.