chore: change emoji version by ideal3147 · Pull Request #2068 · elimu-ai/webapp

ideal3147 · 2025-03-17T22:39:35Z

Issue Number

Resolves Adjust emoji version for Android 8.0 (API 26) #2047

Purpose

This is needed because we are increasing the minimum Android SDK version.

Technical Details

Make adjustments in Entity JavaDoc, Controllers, JSPs:

coderabbitai · 2025-03-17T22:41:49Z

Walkthrough

This update adjusts the supported Unicode and Unicode Emoji versions for emoji processing. The documentation in the Emoji model is updated, the validation logic in both the emoji creation and edit controllers is modified to enforce the new threshold, and the form placeholders in the JSP files are updated accordingly.

Changes

Files	Change Summary
`src/main/java/ai/elimu/model/.../Emoji.java`	Updated JavaDoc comments for `unicodeVersion` and `unicodeEmojiVersion` fields, increasing the specified maximum versions and updating the Unicode data file URL.
`src/main/java/ai/elimu/web/content/emoji/EmojiCreateController.java`, `src/main/java/ai/elimu/web/content/emoji/EmojiEditController.java`	Modified the conditional check in `handleSubmit` to change the Unicode version threshold from >9 to >10.
`src/main/webapp/WEB-INF/jsp/content/emoji/create.jsp`, `src/main/webapp/WEB-INF/jsp/content/emoji/edit.jsp`	Updated placeholder values in form fields from “9.0” to “10.0” for `unicodeVersion` and from “3.0” to “5.0” for `unicodeEmojiVersion`.

Sequence Diagram(s)

sequenceDiagram
    participant U as User
    participant C as EmojiController
    U->>C: Submit emoji data with unicodeVersion
    alt unicodeVersion ≤ 10
        C->>C: Process submission
        C-->>U: Return success response
    else unicodeVersion > 10
        C->>C: Reject submission
        C-->>U: Return error response
    end

Assessment against linked issues

Objective	Addressed	Explanation
Update Entity JavaDoc for emoji Unicode versions (#2047)	✅
Adjust controller validation for Unicode version limits (#2047)	✅
Update JSP placeholder values for Unicode versions (#2047)	✅

Tip

⚡🧪 Multi-step agentic review comment chat (experimental)

We're introducing multi-step agentic chat in review comments. This experimental feature enhances review discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments.
- To enable this feature, set early_access to true under in the settings.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3676edb and 1e4cd04.

📒 Files selected for processing (5)

src/main/java/ai/elimu/model/content/Emoji.java (1 hunks)
src/main/java/ai/elimu/web/content/emoji/EmojiCreateController.java (1 hunks)
src/main/java/ai/elimu/web/content/emoji/EmojiEditController.java (1 hunks)
src/main/webapp/WEB-INF/jsp/content/emoji/create.jsp (1 hunks)
src/main/webapp/WEB-INF/jsp/content/emoji/edit.jsp (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (8)

GitHub Check: test_rest_localhost
GitHub Check: build (windows-latest, 17)
GitHub Check: build (macos-latest, 17)
GitHub Check: build (windows-latest, 21)
GitHub Check: build (ubuntu-latest, 17)
GitHub Check: build (macos-latest, 21)
GitHub Check: build (ubuntu-latest, 21)
GitHub Check: test_ui_localhost

🔇 Additional comments (9)

src/main/java/ai/elimu/web/content/emoji/EmojiCreateController.java (1)

47-47: Validation criteria updated to accept newer Unicode versions

The conditional check has been updated to accept emoji Unicode versions up to 10.0 (inclusive) instead of the previous 9.0 limit. This change aligns with the PR's objective to update supported emoji versions.

src/main/java/ai/elimu/web/content/emoji/EmojiEditController.java (1)

66-66: Validation criteria updated to accept newer Unicode versions

The conditional check has been updated to accept emoji Unicode versions up to 10.0 (inclusive) instead of the previous 9.0 limit. This change maintains consistency with the similar update in EmojiCreateController.

src/main/webapp/WEB-INF/jsp/content/emoji/create.jsp (2)

19-19: Updated Unicode version placeholder

The placeholder has been updated from "9.0" to "10.0" to match the new validation criteria in the controller.

24-24: Updated Unicode Emoji version placeholder

The placeholder has been updated from "3.0" to "5.0", increasing the maximum acceptable Unicode Emoji version.

src/main/webapp/WEB-INF/jsp/content/emoji/edit.jsp (2)

21-21: Updated Unicode version placeholder

The placeholder has been updated from "9.0" to "10.0" to match the new validation criteria in the controller.

26-26: Updated Unicode Emoji version placeholder

The placeholder has been updated from "3.0" to "5.0", increasing the maximum acceptable Unicode Emoji version.

src/main/java/ai/elimu/model/content/Emoji.java (3)

28-28: Correctly updated Unicode version compatibility.

The documentation now properly reflects that Unicode version 10.0 is the maximum supported version for compatibility with Android SDK 8.0 (API level 26). This aligns with the PR objective to update emoji version support.

36-36: Correctly updated Unicode Emoji version compatibility.

The documentation now properly reflects that Unicode Emoji version 5.0 is the maximum supported version for compatibility with Android SDK 8.0 (API level 26). This update is consistent with the other version changes in this PR.

38-38: Updated reference URL.

The reference URL has been appropriately updated to point to the emoji-data.txt file for Unicode Emoji version 5.0 instead of version 3.0, matching the new version requirement specified above.

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

codecov · 2025-03-17T22:43:19Z

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 15.19%. Comparing base (1b94ae9) to head (1e4cd04).
Report is 4 commits behind head on main.

Files with missing lines	Patch %	Lines
...elimu/web/content/emoji/EmojiCreateController.java	0.00%	1 Missing ⚠️
...i/elimu/web/content/emoji/EmojiEditController.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               main    #2068   +/-   ##
=========================================
  Coverage     15.19%   15.19%           
  Complexity      404      404           
=========================================
  Files           243      243           
  Lines          6672     6672           
  Branches        747      747           
=========================================
  Hits           1014     1014           
  Misses         5608     5608           
  Partials         50       50

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

chore: change emoji version

1e4cd04

ideal3147 requested a review from a team as a code owner March 17, 2025 22:39

ideal3147 requested review from SnehaHS65, Souvik-Cyclic and jo-elimu and removed request for a team March 17, 2025 22:39

coderabbitai Bot approved these changes Mar 17, 2025

View reviewed changes

jo-elimu approved these changes Mar 17, 2025

View reviewed changes

jo-elimu merged commit eca4998 into elimu-ai:main Mar 17, 2025
10 checks passed

coderabbitai Bot mentioned this pull request Mar 18, 2025

fix: check sdkVersion when uploading new APK #2069

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: change emoji version#2068

chore: change emoji version#2068
jo-elimu merged 1 commit intoelimu-ai:mainfrom
ideal3147:2047-Adjust-emoji-version-for-Android-8.0-(API-26)

ideal3147 commented Mar 17, 2025

Uh oh!

coderabbitai Bot commented Mar 17, 2025

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

codecov Bot commented Mar 17, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

ideal3147 commented Mar 17, 2025

Issue Number

Purpose

Technical Details

Uh oh!

coderabbitai Bot commented Mar 17, 2025

Walkthrough

Changes

Sequence Diagram(s)

Assessment against linked issues

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

codecov Bot commented Mar 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

CodeRabbit Configuration File (`.coderabbit.yaml`)

codecov Bot commented Mar 17, 2025 •

edited

Loading