-
-
Notifications
You must be signed in to change notification settings - Fork 71
test: improve ui test coverage #2163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| package selenium.content.image; | ||
|
|
||
| import org.openqa.selenium.By; | ||
| import org.openqa.selenium.WebDriver; | ||
|
|
||
| public class ImageCreatePage { | ||
|
|
||
| private WebDriver driver; | ||
|
|
||
| public ImageCreatePage(WebDriver driver) { | ||
| this.driver = driver; | ||
|
|
||
| driver.findElement(By.id("imageCreatePage")); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| package selenium.content.image; | ||
|
|
||
| import org.openqa.selenium.By; | ||
| import org.openqa.selenium.WebDriver; | ||
|
|
||
| public class ImageEditPage { | ||
|
|
||
| private WebDriver driver; | ||
|
|
||
| public ImageEditPage(WebDriver driver) { | ||
| this.driver = driver; | ||
|
|
||
| driver.findElement(By.id("imageEditPage")); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| package selenium.content.image; | ||
|
|
||
| import java.util.List; | ||
|
|
||
| import org.openqa.selenium.By; | ||
| import org.openqa.selenium.WebDriver; | ||
| import org.openqa.selenium.WebElement; | ||
|
|
||
| public class ImageListPage { | ||
|
|
||
| private WebDriver driver; | ||
|
|
||
| public ImageListPage(WebDriver driver) { | ||
| this.driver = driver; | ||
|
|
||
| driver.findElement(By.id("imageListPage")); | ||
| } | ||
|
|
||
| public void pressRandomImage() { | ||
| List<WebElement> links = driver.findElements(By.className("editLink")); | ||
| int randomIndex = (int) (Math.random() * links.size()); | ||
| WebElement randomLink = links.get(randomIndex); | ||
| randomLink.click(); | ||
| } | ||
|
|
||
| public void pressCreateButton() { | ||
| WebElement button = driver.findElement(By.id("createButton")); | ||
| button.click(); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,71 @@ | ||
| package selenium.content.image; | ||
|
|
||
| import org.junit.jupiter.api.AfterEach; | ||
| import org.junit.jupiter.api.BeforeEach; | ||
| import org.junit.jupiter.api.Test; | ||
| import org.openqa.selenium.WebDriver; | ||
| import org.openqa.selenium.chrome.ChromeDriver; | ||
| import org.openqa.selenium.chrome.ChromeOptions; | ||
|
|
||
| import lombok.extern.slf4j.Slf4j; | ||
| import selenium.content.MainContentPage; | ||
| import selenium.util.DomainHelper; | ||
|
|
||
| @Slf4j | ||
| public class ImageTest { | ||
|
|
||
| private WebDriver driver; | ||
|
|
||
| @BeforeEach | ||
| public void setUp() { | ||
| log.info("setUp"); | ||
|
|
||
| ChromeOptions chromeOptions = new ChromeOptions(); | ||
|
|
||
| // Read "headless" property set on the command line: | ||
| // mvn clean verify -P regression-test-ui -D headless=true | ||
| String headlessSystemProperty = System.getProperty("headless"); | ||
| log.info("headlessSystemProperty: \"" + headlessSystemProperty + "\""); | ||
| if ("true".equals(headlessSystemProperty)) { | ||
| chromeOptions.addArguments("headless"); | ||
| } | ||
|
|
||
| driver = new ChromeDriver(chromeOptions); | ||
|
|
||
| driver.get(DomainHelper.getBaseUrl() + "/content"); | ||
| } | ||
|
|
||
| @AfterEach | ||
| public void tearDown() { | ||
| log.info("tearDown"); | ||
|
|
||
| driver.quit(); | ||
| } | ||
|
|
||
| @Test | ||
| public void testRandomImageEditPage() { | ||
| log.info("testRandomImageEditPage"); | ||
|
|
||
| MainContentPage mainContentPage = new MainContentPage(driver); | ||
| mainContentPage.pressImageListLink(); | ||
|
|
||
| ImageListPage imageListPage = new ImageListPage(driver); | ||
| imageListPage.pressRandomImage(); | ||
| log.info("driver.getCurrentUrl(): " + driver.getCurrentUrl()); | ||
|
|
||
| ImageEditPage imageEditPage = new ImageEditPage(driver); | ||
| } | ||
|
jo-elimu marked this conversation as resolved.
|
||
|
|
||
| @Test | ||
| public void testImageCreatePage() { | ||
| log.info("testImageCreatePage"); | ||
|
|
||
| MainContentPage mainContentPage = new MainContentPage(driver); | ||
| mainContentPage.pressImageListLink(); | ||
|
|
||
| ImageListPage imageListPage = new ImageListPage(driver); | ||
| imageListPage.pressCreateButton(); | ||
|
|
||
| ImageCreatePage imageCreatePage = new ImageCreatePage(driver); | ||
| } | ||
|
jo-elimu marked this conversation as resolved.
|
||
| } | ||
15 changes: 15 additions & 0 deletions
15
src/test/java/selenium/content/storybook/StoryBookCreatePage.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| package selenium.content.storybook; | ||
|
|
||
| import org.openqa.selenium.By; | ||
| import org.openqa.selenium.WebDriver; | ||
|
|
||
| public class StoryBookCreatePage { | ||
|
|
||
| private WebDriver driver; | ||
|
|
||
| public StoryBookCreatePage(WebDriver driver) { | ||
| this.driver = driver; | ||
|
|
||
| driver.findElement(By.id("storyBookCreatePage")); | ||
| } | ||
| } |
15 changes: 15 additions & 0 deletions
15
src/test/java/selenium/content/storybook/StoryBookEditPage.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| package selenium.content.storybook; | ||
|
|
||
| import org.openqa.selenium.By; | ||
| import org.openqa.selenium.WebDriver; | ||
|
|
||
| public class StoryBookEditPage { | ||
|
|
||
| private WebDriver driver; | ||
|
|
||
| public StoryBookEditPage(WebDriver driver) { | ||
| this.driver = driver; | ||
|
|
||
| driver.findElement(By.id("storyBookEditPage")); | ||
| } | ||
| } |
30 changes: 30 additions & 0 deletions
30
src/test/java/selenium/content/storybook/StoryBookListPage.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| package selenium.content.storybook; | ||
|
|
||
| import java.util.List; | ||
|
|
||
| import org.openqa.selenium.By; | ||
| import org.openqa.selenium.WebDriver; | ||
| import org.openqa.selenium.WebElement; | ||
|
|
||
| public class StoryBookListPage { | ||
|
|
||
| private WebDriver driver; | ||
|
|
||
| public StoryBookListPage(WebDriver driver) { | ||
| this.driver = driver; | ||
|
|
||
| driver.findElement(By.id("storyBookListPage")); | ||
| } | ||
|
|
||
| public void pressRandomStoryBook() { | ||
| List<WebElement> links = driver.findElements(By.className("editLink")); | ||
| int randomIndex = (int) (Math.random() * links.size()); | ||
| WebElement randomLink = links.get(randomIndex); | ||
| randomLink.click(); | ||
| } | ||
|
|
||
| public void pressCreateButton() { | ||
| WebElement button = driver.findElement(By.id("createButton")); | ||
| button.click(); | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Add error handling for empty lists.
The
pressRandomImage()method assumes that there's at least one edit link on the page. Add error handling for the case when no edit links are found to prevent test failures in unexpected ways.📝 Committable suggestion