Skip to content

refactor(wordgson): use tostring#2342

Merged
jo-elimu merged 1 commit intomainfrom
2194-tostring-instead-of-get-text
Aug 23, 2025
Merged

refactor(wordgson): use tostring#2342
jo-elimu merged 1 commit intomainfrom
2194-tostring-instead-of-get-text

Conversation

@jo-elimu
Copy link
Copy Markdown
Member

#2194

https://github.com/elimu-ai/model/releases/tag/model-2.0.122

Issue Number

  • Resolves #

Purpose

Technical Details

Testing Instructions

Screenshots


Format Checks

Note

Files in PRs are automatically checked for format violations with mvn spotless:check.

If this PR contains files with format violations, run mvn spotless:apply to fix them.

@jo-elimu jo-elimu self-assigned this Aug 23, 2025
@jo-elimu jo-elimu requested a review from a team as a code owner August 23, 2025 15:52
@jo-elimu jo-elimu requested review from alexander-kuruvilla, eymaal and jpatel3 and removed request for a team August 23, 2025 15:52
@jo-elimu jo-elimu merged commit 1094af8 into main Aug 23, 2025
11 of 13 checks passed
@jo-elimu jo-elimu deleted the 2194-tostring-instead-of-get-text branch August 23, 2025 15:52
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Aug 23, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Updates dependency tree with Selenium and OpenTelemetry upgrades. Modifies Word.toString() to delegate to Gson conversion. Adjusts seeded Thai letter text in CustomDispatcherServlet. Updates JSP to conditionally style word links when toString() differs from getText().

Changes

Cohort / File(s) Summary
Dependency graph refresh
pom-dependency-tree.txt
Bumps webapp to 2.6.134-SNAPSHOT and model to 2.0.122. Upgrades selenium-java and transitives to 4.34.0, updates Guava to 33.4.8-jre, shifts commons-exec to runtime via selenium-os, and upgrades OpenTelemetry stack to 1.51.0 with cleanup of deprecated/alpha artifacts.
Entity toString refactor
src/main/java/ai/elimu/entity/content/Word.java
Replaces manual string assembly with JpaToGsonConverter.getWordGson(this).toString(); adds imports for WordGson and JpaToGsonConverter. Signature unchanged.
Seed data text tweak
src/main/java/ai/elimu/web/servlet/CustomDispatcherServlet.java
Changes seeded Letter text for letterAA from "า" to "◌า". No control-flow changes.
UI conditional styling
src/main/webapp/WEB-INF/jsp/content/word/list.jsp
Adds conditional inline style on edit link when word.toString() != word.getText(); link text remains ${word}.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between cfbe867 and cbcbc8c.

⛔ Files ignored due to path filters (1)
  • pom.xml is excluded by !**/*.xml
📒 Files selected for processing (4)
  • pom-dependency-tree.txt (2 hunks)
  • src/main/java/ai/elimu/entity/content/Word.java (2 hunks)
  • src/main/java/ai/elimu/web/servlet/CustomDispatcherServlet.java (1 hunks)
  • src/main/webapp/WEB-INF/jsp/content/word/list.jsp (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch 2194-tostring-instead-of-get-text

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 23, 2025

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.88%. Comparing base (be792c1) to head (cbcbc8c).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
src/main/java/ai/elimu/entity/content/Word.java 0.00% 2 Missing ⚠️
.../ai/elimu/web/servlet/CustomDispatcherServlet.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2342   +/-   ##
=========================================
  Coverage     16.87%   16.88%           
  Complexity      464      464           
=========================================
  Files           264      264           
  Lines          7827     7824    -3     
  Branches        898      897    -1     
=========================================
  Hits           1321     1321           
+ Misses         6430     6427    -3     
  Partials         76       76           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant