Conversation
|
Thanks for the PR @xhrach06. To help our reviewers, could you please give some context as to what the proposed changes specifically address? Ideally in an issue and then link to that issue in the PR. But if you just add it to the PR description, it will also be fine. |
lvarin
left a comment
lvarin
left a comment
There was a problem hiding this comment.
I have lots of questions 😕
| - name: pubgrade | ||
| imagePullPolicy: IfNotPresent | ||
| image: akash7778/pubgrade:test_build | ||
| image: cerit.io/matej_hrachovec/pub_fix:debu |
There was a problem hiding this comment.
This is a very suspicious change. Why change the image? To a different registry and name?
| ingress: | ||
| enabled: true | ||
| url: 'your.url.without.http.com' | ||
| url: 'pupgrade.dyn.cloud.e-infra.cz' |
There was a problem hiding this comment.
This looks like something commited by mistake
| selector: | ||
| app: db | ||
| type: NodePort No newline at end of file | ||
| type: ClusterIP |
There was a problem hiding this comment.
This looks like something that should be parametrized in values.yaml instead of hard wired here
| name: pubgrade-storage | ||
| - name: certconf | ||
| mountPath: /etc/ssl/certs/cert.pem | ||
| subPath: cert.pem |
There was a problem hiding this comment.
The certconf config map does not have this file on it. A PEM file should be in a secret. This is at the very least very confusing. Probably a mistake.
| - name: pubgrade-storage | ||
| persistentVolumeClaim: | ||
| claimName: {{ .Values.volumes.Pubgrade.name }} | ||
| #{{- if .Values.volumes.Pubgrade.deployLocalPv }} |
| volumeMounts: | ||
| - name: pubgrade-storage | ||
| mountPath: {{ .Values.volumes.Pubgrade.pathToMountedDir }} | ||
| #{{end}} |
3 participants
No description provided.