Open
Conversation
Reviewer's Guide by SourceryThis pull request modifies the Ingress resource to be compatible with the networking.k8s.io/v1 API version, removes the openshift route, and updates the helm chart to use a tls secret. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @akash2237778 - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please add a PR description explaining the motivation for removing OpenShift support and simplifying the Ingress configuration. This will help reviewers understand the intended changes and their impact.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| install-pubgrade: # build ## Install pubgrade on cluster using helm. | ||
| # kubectl create namespace $(APP_NAME) --dry-run=client -o yaml | kubectl apply -f - | ||
| helm upgrade --install $(APP_NAME) deployment/ -n $(APP_NAME) | ||
| helm upgrade --install $(APP_NAME) helm/ -n $(APP_NAME)-ns |
There was a problem hiding this comment.
issue (bug_risk): Namespace mismatch between install and uninstall commands will cause uninstall to fail
The uninstall command uses
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Update the Ingress configuration to use a predefined TLS secret and set the host to pubgrade.dyn.cloud.e-infra.cz. Update helm chart path in Makefile.
Build:
Deployment: