Skip to content

Update imagePullPolicy... #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jemaltahir merged 2 commits into from
Jan 9, 2026
Merged

Update imagePullPolicy... #261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b6be22
Update imagePullPolicy...
trispera Jan 5, 2026
e9cedd8
Use the values instead of hard coding
trispera Jan 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions deployment/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@ apiVersion: v2
name: cwlwes
description: A cwl-WES Helm chart for Kubernetes.
type: application
version: 2.0.0
appVersion: 2.0.0
version: 2.0.1
appVersion: 2.0.1
2 changes: 1 addition & 1 deletion deployment/templates/mongodb/mongodb-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ spec:
key: databasePassword
name: {{ .Values.mongodb.appName }}
image: {{ .Values.mongodb.image }}
imagePullPolicy: IfNotPresent
imagePullPolicy: {{ .Values.mongodb.pullPolicy | quote }}
livenessProbe:
failureThreshold: 3
initialDelaySeconds: 30
Expand Down
2 changes: 1 addition & 1 deletion deployment/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ wes:

celeryWorker:
appName: celery-worker
image: elixircloud/cwl-wes:latest
image: lvarin/cwl-wes:20220325
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai bot Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Using a personal Docker Hub namespace and dated tag for celeryWorker image may complicate maintenance and provenance.

While pinning avoids latest, relying on a user-specific repo and a date-based tag may hurt maintainability. If the tag is meant to track the chart/app version, consider aligning it with appVersion, or make the repo and tag configurable (e.g. celeryWorker.image.repository / celeryWorker.image.tag) to ease future updates and avoid drift.

Suggested implementation:

celeryWorker:
  appName: celery-worker
  image:
    # Default to the official repository; can be overridden per environment
    repository: elixircloud/cwl-wes
    # Leave empty to allow templates to default to .Chart.AppVersion if desired
    tag: ""
  initResources:
    limits:
      memory: 16Mi
  1. Update the corresponding Deployment/Job template(s) for the celery worker to use the new structure, e.g.:
    • image: "{{ .Values.celeryWorker.image.repository }}:{{ default .Chart.AppVersion .Values.celeryWorker.image.tag }}".
  2. If you had previously referenced .Values.celeryWorker.image as a single string in any other templates (e.g. in CronJobs or tests), update those references to use .Values.celeryWorker.image.repository and .Values.celeryWorker.image.tag with the same defaulting behavior.
  3. Optionally document the new celeryWorker.image.repository and celeryWorker.image.tag values in the chart README so users know how to override them.

initResources:
limits:
memory: 16Mi
Expand Down