Merged
Conversation
- Update requirements - Update image - Update celery-deployment
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates deployment images to a newer elixircloud/cwl-wes build, aligns the Celery worker command with the new image’s module layout, and bumps setuptools to a newer compatible version to address a Dependabot CVE. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The Celery command now uses
-A workerinstead of-A celery_worker; double-check that this matches the module name exposed in the newelixircloud/cwl-wes:20260116image and that there are no remaining references to the old module name elsewhere in the deployment templates. - The setuptools version constraint changed from
<69to~=78.1.1; consider confirming that any tooling or packaging logic that previously relied on an older setuptools behavior still works and, if needed, using a compatible range rather than a single recent minor pin.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The Celery command now uses `-A worker` instead of `-A celery_worker`; double-check that this matches the module name exposed in the new `elixircloud/cwl-wes:20260116` image and that there are no remaining references to the old module name elsewhere in the deployment templates.
- The setuptools version constraint changed from `<69` to `~=78.1.1`; consider confirming that any tooling or packaging logic that previously relied on an older setuptools behavior still works and, if needed, using a compatible range rather than a single recent minor pin.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Please create an issue before filing a pull request! Changes need to be discussed before proceeding. Please read the contribution guidelines.
Details
Please provide enough information so that others can review your pull request. Give a brief summary of the motivation. Refer to the corresponding issue/s with
#XXXXfor more information.Testing
Write the appropriate unit and integration tests, if applicable. Make sure these and all other tests pass.
Documentation
Please document your changes and test cases in the appropriate places, if applicable.
Style
Make sure your changes adhere to the coding/documentation style used throughout the project.
Closing issues
If your changes fix any issue/s, put
closes #XXXXin your comment to auto-close it/them.Credit
Add your credentials to the list of contributors once your pull request was merged.
Summary by Sourcery
Update runtime and worker images along with Celery configuration and Python packaging dependencies.
Bug Fixes:
Enhancements:
Build:
Deployment: