Skip to content

Allow fields in json_extract_path #4604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 13, 2025
Merged

Allow fields in json_extract_path #4604

merged 5 commits into from
Apr 13, 2025

Conversation

greg-rychlewski
Copy link
Member

companion to elixir-ecto/ecto_sql#660 in Ecto SQL

@greg-rychlewski greg-rychlewski mentioned this pull request Apr 12, 2025
Merged
josevalim
josevalim approved these changes Apr 12, 2025
View reviewed changes
Copy link
Member

@josevalim josevalim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! ❤️ I think we didn't consider this syntax before.

It may not be supported in all adapters but I think that's fine. Unsupported ones can raise.

@greg-rychlewski greg-rychlewski merged commit 6012035 into elixir-ecto:master Apr 13, 2025
4 of 7 checks passed
@greg-rychlewski greg-rychlewski deleted the json_path_with_fields branch April 13, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josevalim josevalim josevalim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@greg-rychlewski @josevalim