Remove test code for compatibility with pre 1.13 elixir #4608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't think it's needed any more. The CI runs with 1.14 on the low end. 1.13 doesn't even get security patches any more, and we're removing _test execution_ support for versions before that even.
|
|
PragTob
commented
Apr 16, 2025
| %RedactAllExceptPrimaryKeysSchema{}, | ||
| %{username: "Hunter", password: "hunter2"}, | ||
| [:username, :password] | ||
| ) |
There was a problem hiding this comment.
this one seemingly was just caused by my mix format, sorry I can remove it if it's too annoying :)
v0idpwn
approved these changes
Apr 16, 2025
|
Looks great! Thanks 💚 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think it's needed any more. The CI runs with 1.14 on the low end. 1.13 doesn't even get security patches any more, and we're removing test execution support for versions before that even.
I had noticed this code due to a check annotation from github on my previous PR and it got me curios: https://github.com/elixir-ecto/ecto/pull/4607/files
Thanks for all your work! 💚