Skip to content

Always return ok or error tuple on connect #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josevalim merged 7 commits into from
Nov 24, 2025
Merged

Always return ok or error tuple on connect #178

Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
46903fc
Always return ok or error tuple on connect
starbelly Nov 24, 2025
9448a14
Remove explicit match for :disconnect in msg_send/2
starbelly Nov 24, 2025
cf04cfb
Refactor TCP connection handling in protocol.ex
josevalim Nov 24, 2025
bf28a06
Update lib/tds/protocol.ex
josevalim Nov 24, 2025
9467f6a
Update lib/tds/protocol.ex
josevalim Nov 24, 2025
637b88e
Update lib/tds/protocol.ex
josevalim Nov 24, 2025
87a823e
Fix indentation and formatting in TCP connection logic
josevalim Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 16 additions & 16 deletions lib/tds/protocol.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,19 +364,22 @@ defmodule Tds.Protocol do
s = %{s | opts: opts}

# Initalize TCP connection with the SQL Server
with {:ok, sock} <- :gen_tcp.connect(host, port, sock_opts, timeout),
{:ok, buffers} <- :inet.getopts(sock, [:sndbuf, :recbuf, :buffer]),
:ok <- :inet.setopts(sock, buffer: max_buf_size(buffers)) do
# Send Prelogin message to SQL Server
case send_prelogin(%{s | sock: {:gen_tcp, sock}}) do
{:error, error, _state} ->
:gen_tcp.close(sock)
{:error, error}

other ->
other
end
else
case :gen_tcp.connect(host, port, sock_opts, timeout) do
{:ok, sock} ->
with {:ok, buffers} <- :inet.getopts(sock, [:sndbuf, :recbuf, :buffer]),
:ok <- :inet.setopts(sock, buffer: max_buf_size(buffers)),
{:ok, s} <- send_prelogin(%{s | sock: {:gen_tcp, sock}}) do
{:ok, s}
else
{:disconnect, exception, _state} ->
:gen_tcp.close(sock)
{:error, exception}

{:error, error} ->
:gen_tcp.close(sock)
{:error, %Tds.Error{message: "tcp connect: #{error}"}}
end

{:error, error} ->
{:error, %Tds.Error{message: "tcp connect: #{error}"}}
end
Expand Down Expand Up @@ -851,9 +854,6 @@ defmodule Tds.Protocol do
buffer
|> IO.iodata_to_binary()
|> decode(s)
else
{:disconnect, _ex, _s} = res -> {0, res}
other -> other
end
end

Expand Down