Skip to content

Add labid as tool_assembly#1799

Open
LauLauThom wants to merge 37 commits intoelixir-europe:masterfrom
LauLauThom:add-labid
Open

Add labid as tool_assembly#1799
LauLauThom wants to merge 37 commits intoelixir-europe:masterfrom
LauLauThom:add-labid

Conversation

@LauLauThom
Copy link
Copy Markdown

Also added the logo of the affiliation to the EMBL Heidelberg, and mentioned LabID in various places where it fits.

I could not build locally for some reason using Docker, I am getting the error

  Liquid Exception: No repo name found. Specify using PAGES_REPO_NWO environment variables, 'repository' in your configuration, or set up an 'origin' git remote pointing to your github.com repository. in /tmp/jekyll-remote-theme-20260303-343-upcia5/_layouts/page.html
             ERROR: YOUR SITE COULD NOT BE BUILT:

this is the repo's config

>git remote -v
origin  https://github.com/LauLauThom/rdmkit.git (fetch)
origin  https://github.com/LauLauThom/rdmkit.git (push)
upstream        https://github.com/elixir-europe/rdmkit.git (fetch)
upstream        https://github.com/elixir-europe/rdmkit.git (push)

Copy link
Copy Markdown
Collaborator

@bianchini88 bianchini88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution. This page is a good starting point, but the format of this page does not follow the typical one for Tools assemblies. See e.g. the Google document here.

Overall, I would appreciate a deeper description of the assembly: numerous integrations are mentioned, but without providing much detail. It would be advisable to describe the user experience a bit more. It is also debatable whether this page really needs two figures when one of them (the logo) is also part of the other (the assembly).

LauLauThom and others added 2 commits March 5, 2026 10:32
Co-authored-by: Federico Bianchini <72258479+bianchini88@users.noreply.github.com>
@LauLauThom
Copy link
Copy Markdown
Author

Hi, thanks for the feedback, I added section to match the recommended format and addeda bit more detail about the features.
I also linked an overview video, I hope that renders correctly.
Thanks !

@bianchini88 bianchini88 self-requested a review March 9, 2026 08:01
Copy link
Copy Markdown
Collaborator

@bianchini88 bianchini88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The video is not picked up (the action expects it to be stored on a repo, and not an external link). I think we will have to discuss internally, as it is unclear how to handle this type of content. We have a meeting on Friday, when this can be addressed.

Question: The video is about something called STOCKS, which does not seem to be mentioned on this page. Could it be that labid and STOCKS are the very same thing? Anyway, some clarifications would be required.

@bianchini88 bianchini88 marked this pull request as draft March 9, 2026 08:11
@bianchini88
Copy link
Copy Markdown
Collaborator

Moving this PR to draft until we decide how to handle the video (likely on Friday).

@LauLauThom
Copy link
Copy Markdown
Author

Could it be that labid and STOCKS are the very same thing?

oh yes indeed ! the project was renamed some years back to avoid confusion, but the interface hasnt changed much so we didnt re-record the videos. I added a small sentence. Talk to you next week most likely for the video then ;)
Thanks !

@bianchini88
Copy link
Copy Markdown
Collaborator

Thank you, @LauLauThom, I will keep you posted.

@bianchini88
Copy link
Copy Markdown
Collaborator

what do you think of the alternative proposal?

Looks good, and could be implemented on other pages as well.

@LauLauThom
Copy link
Copy Markdown
Author

Hey @LauLauThom I would just link to the video for now since there is no easy way to embed this right now in RDMkit unless it is on a video streaming website with embed capabilities, like YouTube.

I changed to a link as recommended. The video is on a S3 bucket with public access, not sure this supports embedding

@bedroesb bedroesb marked this pull request as ready for review March 25, 2026 08:26
@bedroesb
Copy link
Copy Markdown
Member

@LauLauThom Thanks a lot for the changes. We have brought this PR up in our latest editorial meeting and have concluded that this PR is close to being merged. @bianchini88 will give this a final check. Thank you for hanging in there!

LauLauThom and others added 2 commits April 7, 2026 10:15
Co-authored-by: Federico Bianchini <72258479+bianchini88@users.noreply.github.com>
@bianchini88
Copy link
Copy Markdown
Collaborator

@LauLauThom, I fixed a couple of additional minor issues in the last few commits. The page is now up to standard and can be published. There is one final issue related to the logo. As you can see in the screenshot below, this will be the only entry on "Tool Assembly" with a logo. I would consider this unfair towards the other resources listed. We could either bring back the page without the logo and publish the content now, or update all the logos as part of this PR. I think the former solution would be cleaner (and more immediate), and then we can create logos for all the "assemblies" independently in the near future. Any opinions? Tagging also @bedroesb

image

@LauLauThom
Copy link
Copy Markdown
Author

@bianchini88 Thanks for the thorough review ! Sure I don't mind having the logo removed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants