Add labid as tool_assembly#1799
Conversation
also link to data provenance
Add LabID documentation for FAIR data management platform
bianchini88
left a comment
There was a problem hiding this comment.
Thank you for the contribution. This page is a good starting point, but the format of this page does not follow the typical one for Tools assemblies. See e.g. the Google document here.
Overall, I would appreciate a deeper description of the assembly: numerous integrations are mentioned, but without providing much detail. It would be advisable to describe the user experience a bit more. It is also debatable whether this page really needs two figures when one of them (the logo) is also part of the other (the assembly).
Co-authored-by: Federico Bianchini <72258479+bianchini88@users.noreply.github.com>
|
Hi, thanks for the feedback, I added section to match the recommended format and addeda bit more detail about the features. |
bianchini88
left a comment
There was a problem hiding this comment.
The video is not picked up (the action expects it to be stored on a repo, and not an external link). I think we will have to discuss internally, as it is unclear how to handle this type of content. We have a meeting on Friday, when this can be addressed.
Question: The video is about something called STOCKS, which does not seem to be mentioned on this page. Could it be that labid and STOCKS are the very same thing? Anyway, some clarifications would be required.
|
Moving this PR to draft until we decide how to handle the video (likely on Friday). |
oh yes indeed ! the project was renamed some years back to avoid confusion, but the interface hasnt changed much so we didnt re-record the videos. I added a small sentence. Talk to you next week most likely for the video then ;) |
|
Thank you, @LauLauThom, I will keep you posted. |
Looks good, and could be implemented on other pages as well. |
I changed to a link as recommended. The video is on a S3 bucket with public access, not sure this supports embedding |
Co-authored-by: Federico Bianchini <72258479+bianchini88@users.noreply.github.com>
|
@LauLauThom Thanks a lot for the changes. We have brought this PR up in our latest editorial meeting and have concluded that this PR is close to being merged. @bianchini88 will give this a final check. Thank you for hanging in there! |
Co-authored-by: Federico Bianchini <72258479+bianchini88@users.noreply.github.com>
Minor style fixes and typos
|
@LauLauThom, I fixed a couple of additional minor issues in the last few commits. The page is now up to standard and can be published. There is one final issue related to the logo. As you can see in the screenshot below, this will be the only entry on "Tool Assembly" with a logo. I would consider this unfair towards the other resources listed. We could either bring back the page without the logo and publish the content now, or update all the logos as part of this PR. I think the former solution would be cleaner (and more immediate), and then we can create logos for all the "assemblies" independently in the near future. Any opinions? Tagging also @bedroesb
|
|
@bianchini88 Thanks for the thorough review ! Sure I don't mind having the logo removed :) |

Also added the logo of the affiliation to the EMBL Heidelberg, and mentioned LabID in various places where it fits.
I could not build locally for some reason using Docker, I am getting the error
this is the repo's config