Skip to content

feat: allow explicitly disabling CUDA step #1588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 6, 2025
Merged

feat: allow explicitly disabling CUDA step #1588

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7b0cdd1
feat: allow explicitly disabling CUDA step
polvalente Mar 5, 2025
2d42cc3
chore: changes due to code rewview
polvalente Mar 6, 2025
f6eb9e4
Merge branch 'main' into pv-fix/exla-cuda-checks
polvalente Mar 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions exla/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,27 +36,29 @@ else
CFLAGS += -O3
endif

NVCC := $(CXX)
NVCCFLAGS = $(CFLAGS)
LDFLAGS = -L$(XLA_EXTENSION_LIB) -lxla_extension -shared -fvisibility=hidden

ifeq ($(CROSSCOMPILE),)
# Interrogate the system for local compilation
UNAME_S = $(shell uname -s)

ifdef ($(EXLA_CPU_ONLY),)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be ifndef? I see "EXLA_CPU_ONLY is set, skipping nvcc step" in an environment where I haven't set EXLA_CPU_ONLY

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup. Fixing it now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5ecc82f

Fixed it. This is a remnant from the original solution for checking equality. The proper usage for ifdef/ifndef doesn't use the same syntax

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoa! Thanks for the quick fix. Hope you have a good weekend!

$(info EXLA_CPU_ONLY is not set, checking for nvcc availability)
NVCC_RESULT := $(shell which nvcc 2> /dev/null)
NVCC_TEST := $(notdir $(NVCC_RESULT))

ifeq ($(NVCC_TEST),nvcc)
NVCC := nvcc
NVCCFLAGS += -DCUDA_ENABLED
ifeq ($(NVCC_TEST),nvcc)
NVCC := nvcc
NVCCFLAGS += -DCUDA_ENABLED
endif
else
NVCC := $(CXX)
NVCCFLAGS = $(CFLAGS)
$(info EXLA_CPU_ONLY is set, skipping nvcc step)
endif
else
# Determine settings for cross-compiled builds like for Nerves
UNAME_S = Linux
NVCC := $(CXX)
NVCCFLAGS = $(CFLAGS)
endif

ifeq ($(UNAME_S), Darwin)
Expand Down
2 changes: 2 additions & 0 deletions exla/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,8 @@ EXLA relies on the [XLA](https://github.com/elixir-nx/xla) package to provide th
* Incompatible protocol buffer versions
* Error message: "this file was generated by an older version of protoc which is incompatible with your Protocol Buffer headers".
* If you have `protoc` installed on your machine, it may conflict with the `protoc` precompiled inside XLA. Uninstall, unlink, or remove `protoc` from your path to continue.
* Missing CUDA symbols
* In some cases, you might be compiling a CPU-only version of `:xla` in an environment that has CUDA available. For these cases, you can set the `EXLA_CPU_ONLY` environment variable to any value to disable custom CUDA functionality in EXLA.

### Usage with Nerves

Expand Down