fix: added do_shard_jit_apply/4 + prepare_options/3 for __shard_jit__ #1650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re_options/3 on compiler.ex
polvalente
reviewed
Dec 26, 2025
nx/lib/nx/defn/compiler.ex
Outdated
Comment on lines
184
to
186
| defp prepare_options(fun, _mesh, opts) do # This is a placeholder for sharding implementation | ||
| prepare_options(fun, opts) | ||
| end |
Contributor
There was a problem hiding this comment.
This a placeholder for what exactly? I think we could just not pass the mesh and reuse the same prepare_options directly
Contributor
Author
There was a problem hiding this comment.
This a placeholder for what exactly? I think we could just not pass the mesh and reuse the same
prepare_optionsdirectly
You're right! No need to pass mesh to prepare_options. maintaining it as arity /2 only
polvalente
approved these changes
Dec 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
do_shard_jit_apply was not defined yet. Also, compiler function shard_jit passes a mesh to prepare_options, which is now accepting it.