Use ensure_compiled! instead of ensure_loaded? on map typespec macro#405
Merged
whatyouhide merged 1 commit intomainfrom Apr 25, 2025
Merged
Use ensure_compiled! instead of ensure_loaded? on map typespec macro#405whatyouhide merged 1 commit intomainfrom
ensure_compiled! instead of ensure_loaded? on map typespec macro#405whatyouhide merged 1 commit intomainfrom
Conversation
yordis
approved these changes
Apr 22, 2025
whatyouhide
reviewed
Apr 24, 2025
v0idpwn
force-pushed
the
fix/ensure-compiled
branch
from
c7e5f90 to
e8d8d7f
Compare
Instead of raising, holds the file compilation until the module is available. Solves compilation issue when using `one_file_per_module=true` and map types, where it would raise due to `Code.ensure_loaded?` returning false for a module that wasn't compiled yet. Co-authored-by: Yordis Prieto <yordis.prieto@gmail.com>
v0idpwn
force-pushed
the
fix/ensure-compiled
branch
from
e8d8d7f to
23aa060
Compare
Collaborator
Author
|
Merged the CI changes (with your comments fixed) on #407 and rebased this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of raising, holds the file compilation until the module is available.
Solves compilation issue when using
one_file_per_module=trueand map types, where it would raise due toCode.ensure_loaded?returning false for a module that wasn't compiled yet.