Add conversions between Google.Protobuf.Duration and Duration#406
Merged
whatyouhide merged 1 commit intoelixir-protobuf:mainfrom Apr 25, 2025
Merged
Add conversions between Google.Protobuf.Duration and Duration#406whatyouhide merged 1 commit intoelixir-protobuf:mainfrom
whatyouhide merged 1 commit intoelixir-protobuf:mainfrom
Conversation
yordis
force-pushed
the
add-duration-support
branch
3 times, most recently
from
427aa7c to
2ac386c
Compare
whatyouhide
reviewed
Apr 24, 2025
Collaborator
whatyouhide
left a comment
whatyouhide
left a comment
There was a problem hiding this comment.
Love it. Left just a couple of comments to address before merging.
whatyouhide
changed the title
yordis
force-pushed
the
add-duration-support
branch
from
2ac386c to
9519e21
Compare
yordis
force-pushed
the
add-duration-support
branch
from
9519e21 to
99acd5a
Compare
Contributor
Author
|
@whatyouhide ready |
whatyouhide
approved these changes
Apr 25, 2025
Collaborator
|
Thank you @yordis! 💟 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.