Skip to content

Conversation

Zurga
Copy link

@Zurga Zurga commented May 2, 2025

Sometimes the Ecto.Adapters.SQL.Sandbox is not a good fit when testing. If Postgres triggers are setup, the sandbox will not trigger them because the transaction is not comitted. For that reason it might be good to be able to disable the sandbox on a Case basis.

This PR adds a :sandbox opt to use Wallaby.Feature allowing the caller to disable the sandbox, even if they have the module loaded.

@mhanberg
Copy link
Member

mhanberg commented May 2, 2025

If you don't want to automatically checkout the ecto repos, you might be better off just importing Wallaby.Feature instead of "use" it.

That would require starting the session manually, however

@Zurga
Copy link
Author

Zurga commented May 2, 2025 via email

@mhanberg
Copy link
Member

mhanberg commented May 2, 2025

You still get automatic screenshots if you use the feature macro, which you get by importing Wallaby.Feature

@Zurga
Copy link
Author

Zurga commented May 2, 2025

Ah yes you are correct! If you are not inclined to merge this PR, feel free to close it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants