Commit 0027024
Shaw
revert(ci): drop ineffective PYTEST_ADDOPTS xprocess workaround
Reading xprocess source (pytest_xprocess.py) confirms my earlier theory
was wrong: pytest_unconfigure only prints a reminder, XProcess.__exit__
is a no-op for cleanup, and process management only kicks in when a test
actually uses the xprocess fixture (none in this repo do). So
`-p no:xprocess` is a functional no-op and the comment was misleading.
The previous successful Plugin Tests run (25231778987) shows
"test test_pty_command has been running for over 60 seconds" for
plugin-shell rust — only one such warning, meaning it eventually
finished. So plugin-shell has a slow / occasionally-hung PTY test, but
not the deterministic infinite hang I claimed.
Keep the 35m step-level timeout (it's still the right blast-radius cap)
and update its comment to reflect the actual suspected cause.1 parent 10aa20f commit 0027024
1 file changed
Lines changed: 3 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
107 | 107 | | |
108 | 108 | | |
109 | 109 | | |
110 | | - | |
111 | | - | |
112 | | - | |
113 | | - | |
114 | | - | |
115 | | - | |
116 | 110 | | |
117 | 111 | | |
118 | 112 | | |
| |||
133 | 127 | | |
134 | 128 | | |
135 | 129 | | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
136 | 133 | | |
137 | 134 | | |
138 | 135 | | |
| |||
0 commit comments