Skip to content

Commit 0027024

Browse files
author
Shaw
committed
revert(ci): drop ineffective PYTEST_ADDOPTS xprocess workaround
Reading xprocess source (pytest_xprocess.py) confirms my earlier theory was wrong: pytest_unconfigure only prints a reminder, XProcess.__exit__ is a no-op for cleanup, and process management only kicks in when a test actually uses the xprocess fixture (none in this repo do). So `-p no:xprocess` is a functional no-op and the comment was misleading. The previous successful Plugin Tests run (25231778987) shows "test test_pty_command has been running for over 60 seconds" for plugin-shell rust — only one such warning, meaning it eventually finished. So plugin-shell has a slow / occasionally-hung PTY test, but not the deterministic infinite hang I claimed. Keep the 35m step-level timeout (it's still the right blast-radius cap) and update its comment to reflect the actual suspected cause.
1 parent 10aa20f commit 0027024

1 file changed

Lines changed: 3 additions & 6 deletions

File tree

.github/workflows/test.yml

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -107,12 +107,6 @@ jobs:
107107
TURBO_TOKEN: ${{ secrets.TURBO_TOKEN }}
108108
TURBO_TEAM: ${{ vars.TURBO_TEAM }}
109109
TURBO_REMOTE_ONLY: true
110-
# Several plugins declare pytest-xprocess as a dev dep but none use it.
111-
# Its pytest_terminal_summary hook was the last thing to print before
112-
# plugin-tests hung for 33 minutes in run 25234887145, so disable it
113-
# globally as a precaution. Safe: `-p no:NAME` is a no-op when NAME
114-
# isn't installed.
115-
PYTEST_ADDOPTS: "-p no:xprocess"
116110
steps:
117111
- uses: actions/checkout@v6
118112
with:
@@ -133,6 +127,9 @@ jobs:
133127
no-vision-deps: "true"
134128

135129
- name: Run plugin tests
130+
# Cap step well below the 60m job budget so a flaky plugin
131+
# (most recently plugin-shell rust PTY tests in run 25234887145)
132+
# fails fast instead of burning the whole job's wall clock.
136133
timeout-minutes: 35
137134
run: bun run test:plugins
138135

0 commit comments

Comments
 (0)