fix(ui): expire steward tokens with malformed exp#11098
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
|
QA review: strict-numeric exp check is correct per JWT NumericDate (a string exp is malformed and must not survive the 401 keep-path). Ran StewardProviderShared.test.ts on the PR head in an isolated worktree: 8/8 pass including the new regression test. |
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
Summary
expclaims as expiredexpvalues cannot survive the 401 keep-pathEvidence
bun run --cwd packages/ui test -- src/cloud/shell/StewardProviderShared.test.ts src/cloud/shell/StewardProviderRuntime.test.tsx src/cloud/public-pages/pages/auth/email-callback-page.test.tsxbunx biome check packages/ui/src/cloud/shell/StewardProviderShared.ts packages/ui/src/cloud/shell/StewardProviderShared.test.tsbun run --cwd packages/ui typecheckbun run --cwd packages/app audit:apppassed 349 captures on the reviewed patch: broken=0, needs-work=0Follow-up from review of #11067.