Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/apple-store-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ jobs:
name: Build & Submit iOS
needs: prepare
if: needs.prepare.outputs.build_ios == 'true'
runs-on: macos-14
runs-on: macos-15
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Implicit Xcode 16 upgrade — no version pinned

macos-15 runners default to Xcode 16, while macos-14 defaulted to Xcode 15. Since neither the build-ios nor build-macos jobs pin an Xcode version with xcode-select, both will silently pick up Xcode 16. CocoaPods compatibility with Xcode 16 and any Swift concurrency/compiler changes between the two major versions should be verified before relying on this in production releases.

timeout-minutes: 60
env:
APPLE_ID: ${{ secrets.APPLE_ID }}
Expand Down Expand Up @@ -275,7 +275,7 @@ jobs:
name: Build & Submit macOS
needs: prepare
if: needs.prepare.outputs.build_macos == 'true'
runs-on: macos-14
runs-on: macos-15
timeout-minutes: 75
env:
APPLE_ID: ${{ secrets.APPLE_ID }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release-electrobun.yml
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,7 @@ jobs:
name: Build Agent Browser Bridge companions
if: ${{ inputs.platform == '' || inputs.platform == 'all' }}
needs: [prepare, validate-release]
runs-on: macos-14
runs-on: macos-15
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Runner version split between companion and main build matrix

build-browser-companions is now on macos-15, but the prepare step's desktop matrix still emits macos-14 for Apple Silicon (lines 139/145) and macos-15-intel for Intel. If the Safari browser-extension companion needs to target the same OS baseline as the shipped .app, building it on a newer OS may produce a binary incompatible with the macOS build produced by the build matrix. Consider aligning the runner or at minimum documenting the intentional split.

timeout-minutes: 60
outputs:
packaged: ${{ steps.package-browser-bridge.outputs.packaged }}
Expand Down
Loading