wip: checkpoint before workflow fixes#7749
Conversation
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Claude encountered an error after 0s —— View job I'll analyze this and get back to you. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| <pre className="os-code">brew install elizaos</pre> | ||
| </a> | ||
| <a href={cloudUrl} className="download-line"> | ||
| <span>Android</span> | ||
| <strong>APK + AOSP image</strong> | ||
| <a href={betaManifestUrl} className="install-card"> | ||
| <div className="install-card-head"> | ||
| <span>Android</span> | ||
| <strong>APK + AOSP image</strong> | ||
| </div> | ||
| <pre className="os-code">adb install elizaos.apk</pre> | ||
| </a> | ||
| </div> |
There was a problem hiding this comment.
The Android install-card now links to betaManifestUrl (/downloads/elizaos-beta-manifest.json), a raw JSON file. Before this PR, the Android link pointed to cloudUrl (https://elizacloud.ai/login?intent=launch). Clicking the card will serve raw JSON in the browser rather than initiating a download or directing users to a download page, which is a regression from the previous behaviour.
| value: "1", | ||
| domain: "127.0.0.1", | ||
| path: "/", | ||
| httpOnly: false, | ||
| secure: false, | ||
| sameSite: "Lax", | ||
| }, | ||
| ]); | ||
| await page.route("**/api/**", (route) => | ||
| route.fulfill({ | ||
| json: { | ||
| success: true, | ||
| data: [], |
There was a problem hiding this comment.
127.0.0.1 domain instead of localhost
The cookie domain is hardcoded to "127.0.0.1". Playwright's dev server typically listens on localhost, and browsers treat localhost and 127.0.0.1 as distinct origins for cookie matching. The cookie will not be sent with requests to localhost, making the mock authentication ineffective and causing the dashboard non-redirect assertion to pass for the wrong reason.
| }); | ||
|
|
||
| test("checkout route renders preorder UI", async ({ page }) => { |
There was a problem hiding this comment.
toContainText(/sign in/i) assumes the login page's h1 always includes the phrase "sign in". If the heading reads "Log in", "Welcome back", or anything without "sign in", this test will fail as a false negative rather than catching a real regression. Consider asserting the URL (/login) alone, or matching a more stable selector.
|
|
||
| test.use({ baseURL: LIVE_URL }); | ||
|
|
There was a problem hiding this comment.
test.use({ baseURL: LIVE_URL }) called with a potentially undefined value
test.use({ baseURL: LIVE_URL }) executes unconditionally even when LIVE_URL is undefined (the skip-guard only prevents the test bodies from running). Passing undefined as baseURL can override the default base URL, causing test helpers that rely on it to resolve paths incorrectly if tests are ever partially unskipped. Guard this call or move it inside a conditional setup.
1 participant
Relates to
Risks
Background
What does this PR do?
What kind of change is this?
Documentation changes needed?
Testing
Where should a reviewer start?
Detailed testing steps
Greptile Summary
A wide-ranging brand/design checkpoint that touches 86 files across the
cloud-frontend,os-homepage,homepage, anduipackages. The primary theme is a global radius system update (zero-radius → 2–4 px tokens), removal ofbackdrop-blurfrom UI surfaces, and a full visual refresh of the os-homepage hero (cloud video), installer layout (tile cards), and hardware section (grid tiles).packages/ui/src/styles/base.cssupdates all--radius-*tokens, affecting every component that uses Tailwindrounded-sm/md/lg; dozens of cloud-frontend files were updated to userounded-smexplicitly.install-cardtiles showing inline shell commands; hardware rows replaced with a responsivehw-gridtile layout; social links (GitHub, X) added to footer.packages/ui-storiesintroduced as a Storybook-style visual catalog; three new Playwright specs add error-capture and title-validation infrastructure; several scripts (knip-workspaces.mjs,personality-bench-bridge.mjs,route-catalog.ts) are deleted.Confidence Score: 3/5
The Android install card links to a raw JSON manifest file, which is a regression for users who click it. The new Playwright auth mocking uses a cookie domain that won't match a localhost test server, making those tests unreliable. The radius and visual changes are widespread but low-risk.
Two defects stand out: the os-homepage Android install card changed its href from the cloud URL to a
.jsonmanifest file (users will land on raw JSON), and the brand-flows Playwright spec mocks authentication with a cookie whose domain (127.0.0.1) will not be sent to alocalhostorigin, meaning those dashboard-redirect assertions are not actually testing what they claim to test. The rest of the PR — radius token standardisation, backdrop-blur removal, ui-stories bootstrap, improved user-menu fetch hardening — is straightforward and low-risk.packages/os-homepage/src/App.tsx (Android install href regression) and packages/cloud-frontend/tests/e2e/brand-flows.spec.ts (cookie domain mismatch in auth mocking)
Important Files Changed
127.0.0.1which won't match alocalhosttest server, and the login-page heading assertion is fragile.CLOUD_E2E_LIVE_URLis set. Minor issue:test.use({ baseURL: undefined })called unconditionally.console.logstatements with structuredlogger.debugcalls; minor improvement to logging hygiene.@elizaos/ui-storiespackage for visual component catalog. Dependencies are plausible; no structural issues.Accept: application/jsonheader and content-type guard before parsing, preventing JSON parse errors on HTML redirect responses.rounded-2xl/rounded-xlreplaced withrounded-sm, andbackdrop-blur-mdremoved from dropdown menus, consistent with the radius token update.Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD A[User visits os-homepage /] --> B[CloudHero section\ncloud video background] B --> C{User action} C -->|Click Download| D[#download section\ninstall-cards: Linux, Mac, Android] C -->|Click Hardware| E[#hardware section\nhw-grid tiles] D --> D1[Linux PC → betaManifestUrl JSON] D --> D2[Mac/Windows/Linux → appUrl] D --> D3[Android → betaManifestUrl JSON ⚠️] E --> F[Individual hw-tile\nlinks to /hardware/:slug] F --> G[ProductDetail page\nHeader solid=true]Reviews (1): Last reviewed commit: "wip: checkpoint before workflow fixes" | Re-trigger Greptile