Skip to content

fix(release): restore desktop release inputs#7826

Merged
lalalune merged 8 commits into
developfrom
shaw/release-followup-platform-fixes
May 20, 2026
Merged

fix(release): restore desktop release inputs#7826
lalalune merged 8 commits into
developfrom
shaw/release-followup-platform-fixes

Conversation

@lalalune
Copy link
Copy Markdown
Member

@lalalune lalalune commented May 20, 2026

Supersedes #7812 after the original PR closed while resolving release blockers.\n\nIncludes the rebased release fixes and CI unblockers for Cloud Tests schema mocks.

Greptile Summary

This PR makes two targeted fixes: it tightens the lockfile integrity gate in the env-audit CI workflow, and removes the @testing-library/dom dependency in a TUI test by introducing a lightweight getElementByText helper backed by native DOM APIs.

  • feed-env-audit.yml: Replaces an unconditional --no-frozen-lockfile with a two-stage strategy — attempt --frozen-lockfile first and only fall back to --no-frozen-lockfile when it fails, then verifying bun.lock is byte-for-byte unchanged via git diff --exit-code.
  • game-tui-mounted-surfaces.test.tsx: Drops the @testing-library/dom import, adds a local getElementByText helper that matches elements by exact trimmed textContent, and swaps fireEvent.click(screen.getByText(…)) for getElementByText(container, …).click().

Confidence Score: 5/5

Safe to merge — both changes are narrow, well-reasoned fixes with no impact on production runtime behavior.

The workflow change adds a stricter lockfile integrity gate (frozen first, unfrozen fallback only when bun.lock is verified unchanged) without removing any existing protection. The test change swaps @testing-library/dom helpers for a local equivalent backed by native DOM APIs, which behaves identically under jsdom with React's event delegation. Neither change touches production code paths.

No files require special attention.

Important Files Changed

Filename Overview
.github/workflows/feed-env-audit.yml Upgrades dependency install step to try frozen lockfile first and only permit the unfrozen fallback when bun.lock is verified byte-for-byte unchanged; clean and correct improvement.
packages/agent/src/tests/game-tui-mounted-surfaces.test.tsx Removes @testing-library/dom dependency, introduces getElementByText helper for exact textContent matching, and uses native .click() — functionally equivalent for jsdom+React event delegation.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[bun install --frozen-lockfile] -->|success| B[exit 0 ✅]
    A -->|failure| C[bun install --no-frozen-lockfile]
    C --> D[git diff --exit-code -- bun.lock]
    D -->|unchanged| E[continue ✅]
    D -->|changed| F[CI failure ❌]
Loading

Comments Outside Diff (1)

  1. packages/scripts/audit-capability-router-live-ci.ts, line 268-291 (link)

    P2 Regex patterns now enforce element order

    The original patterns used zero-width lookaheads ((?=[\s\S]*...)) anchored at the same position, so all tokens were asserted to exist anywhere in the content regardless of order. The new patterns are sequential — each [\s\S]{0,N} span must follow the previous token in source order. For the three affected checks (redacted product trust audit records, Cloud provision restart reopened view, signed provenance trust policy) this is a semantic change: if the target test file has the required tokens in a different order than the new regex expects, the check will spuriously report an audit failure. Worth verifying the token order in the actual test file matches the new sequence before relying on these patterns in CI.

Reviews (15): Last reviewed commit: "Merge remote-tracking branch 'origin/dev..." | Re-trigger Greptile

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 20, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7cf61ee7-c342-4395-b51c-4e62cb88a361

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch shaw/release-followup-platform-fixes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Comment thread plugins/plugin-agent-orchestrator/__tests__/unit/spawn-agent.test.ts Outdated
@lalalune lalalune force-pushed the shaw/release-followup-platform-fixes branch 6 times, most recently from 9a8715b to 533bfd1 Compare May 20, 2026 05:14
@claude
Copy link
Copy Markdown
Contributor

claude Bot commented May 20, 2026

Claude Code is working…

I'll analyze this and get back to you.

View job run

@github-actions
Copy link
Copy Markdown
Contributor

LifeOps Benchmark — eliza

Run ID: lifeops-eliza-26146046108

LifeOps Benchmark

Model: gpt-oss-120b
Judge: claude-opus-4-7
Scenarios: 25
pass@1: 0.000
pass@k: 0.000
Total cost: $0.0000

Full artifacts: see the lifeops-run-eliza-26146046108 upload on this run.

@github-actions
Copy link
Copy Markdown
Contributor

LifeOps Benchmark — hermes

Run ID: lifeops-hermes-26146046108

LifeOps Benchmark

Model: gpt-oss-120b
Judge: claude-opus-4-7
Scenarios: 25
pass@1: 0.200
pass@k: 0.200
Total cost: $0.9522

Full artifacts: see the lifeops-run-hermes-26146046108 upload on this run.

@github-actions
Copy link
Copy Markdown
Contributor

LifeOps Multi-Tier Benchmark

Suite: smoke — Tiers requested: large,frontier

large

LifeOps Multi-Tier Benchmark

Tier: large
Suite: smoke

frontier

LifeOps Multi-Tier Benchmark

Tier: frontier
Suite: smoke

Artifacts: lifeops-multi-tier-large-26146046106, lifeops-multi-tier-frontier-26146046106

@github-actions
Copy link
Copy Markdown
Contributor

LifeOps Benchmark — eliza

Run ID: lifeops-eliza-26148048086

LifeOps Benchmark

Model: gpt-oss-120b
Judge: claude-opus-4-7
Scenarios: 25
pass@1: 0.000
pass@k: 0.000
Total cost: $0.0000

Full artifacts: see the lifeops-run-eliza-26148048086 upload on this run.

@github-actions
Copy link
Copy Markdown
Contributor

LifeOps Benchmark — hermes

Run ID: lifeops-hermes-26148048086

LifeOps Benchmark

Model: gpt-oss-120b
Judge: claude-opus-4-7
Scenarios: 25
pass@1: 0.240
pass@k: 0.240
Total cost: $0.8401

Full artifacts: see the lifeops-run-hermes-26148048086 upload on this run.

@github-actions
Copy link
Copy Markdown
Contributor

LifeOps Multi-Tier Benchmark

Suite: smoke — Tiers requested: large,frontier

large

LifeOps Multi-Tier Benchmark

Tier: large
Suite: smoke

frontier

LifeOps Multi-Tier Benchmark

Tier: frontier
Suite: smoke

Artifacts: lifeops-multi-tier-large-26148048141, lifeops-multi-tier-frontier-26148048141

@elizaOS elizaOS deleted a comment from claude Bot May 20, 2026
@elizaOS elizaOS deleted a comment from claude Bot May 20, 2026
@elizaOS elizaOS deleted a comment from claude Bot May 20, 2026
@elizaOS elizaOS deleted a comment from claude Bot May 20, 2026
@elizaOS elizaOS deleted a comment from claude Bot May 20, 2026
@elizaOS elizaOS deleted a comment from claude Bot May 20, 2026
@elizaOS elizaOS deleted a comment from claude Bot May 20, 2026
@elizaOS elizaOS deleted a comment from claude Bot May 20, 2026
@elizaOS elizaOS deleted a comment from claude Bot May 20, 2026
@elizaOS elizaOS deleted a comment from claude Bot May 20, 2026
@lalalune lalalune closed this May 20, 2026
@lalalune lalalune reopened this May 20, 2026
…wup-platform-fixes-final

# Conflicts:
#	packages/agent/src/__tests__/game-tui-mounted-surfaces.test.tsx
@claude
Copy link
Copy Markdown
Contributor

claude Bot commented May 20, 2026

Claude encountered an error —— View job


I'll analyze this and get back to you.

@claude
Copy link
Copy Markdown
Contributor

claude Bot commented May 20, 2026

Claude encountered an error —— View job


I'll analyze this and get back to you.

@github-actions github-actions Bot added the ci label May 20, 2026
…wup-platform-fixes-final

# Conflicts:
#	.github/workflows/feed-env-audit.yml
@claude
Copy link
Copy Markdown
Contributor

claude Bot commented May 20, 2026

Claude encountered an error —— View job


I'll analyze this and get back to you.

@lalalune lalalune merged commit 67e922a into develop May 20, 2026
31 checks passed
@lalalune lalalune deleted the shaw/release-followup-platform-fixes branch May 20, 2026 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant