fix(release): restore desktop release inputs#7826
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
9a8715b to
533bfd1
Compare
|
I'll analyze this and get back to you. |
LifeOps Benchmark —
|
LifeOps Benchmark —
|
LifeOps Multi-Tier BenchmarkSuite:
|
…wup-platform-fixes-final
LifeOps Benchmark —
|
LifeOps Benchmark —
|
LifeOps Multi-Tier BenchmarkSuite:
|
…wup-platform-fixes-final # Conflicts: # packages/agent/src/__tests__/game-tui-mounted-surfaces.test.tsx
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
…wup-platform-fixes-final
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
…wup-platform-fixes-final # Conflicts: # .github/workflows/feed-env-audit.yml
|
Claude encountered an error —— View job I'll analyze this and get back to you. |

Supersedes #7812 after the original PR closed while resolving release blockers.\n\nIncludes the rebased release fixes and CI unblockers for Cloud Tests schema mocks.
Greptile Summary
This PR makes two targeted fixes: it tightens the lockfile integrity gate in the env-audit CI workflow, and removes the
@testing-library/domdependency in a TUI test by introducing a lightweightgetElementByTexthelper backed by native DOM APIs.--no-frozen-lockfilewith a two-stage strategy — attempt--frozen-lockfilefirst and only fall back to--no-frozen-lockfilewhen it fails, then verifyingbun.lockis byte-for-byte unchanged viagit diff --exit-code.@testing-library/domimport, adds a localgetElementByTexthelper that matches elements by exact trimmedtextContent, and swapsfireEvent.click(screen.getByText(…))forgetElementByText(container, …).click().Confidence Score: 5/5
Safe to merge — both changes are narrow, well-reasoned fixes with no impact on production runtime behavior.
The workflow change adds a stricter lockfile integrity gate (frozen first, unfrozen fallback only when bun.lock is verified unchanged) without removing any existing protection. The test change swaps @testing-library/dom helpers for a local equivalent backed by native DOM APIs, which behaves identically under jsdom with React's event delegation. Neither change touches production code paths.
No files require special attention.
Important Files Changed
Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD A[bun install --frozen-lockfile] -->|success| B[exit 0 ✅] A -->|failure| C[bun install --no-frozen-lockfile] C --> D[git diff --exit-code -- bun.lock] D -->|unchanged| E[continue ✅] D -->|changed| F[CI failure ❌]Comments Outside Diff (1)
packages/scripts/audit-capability-router-live-ci.ts, line 268-291 (link)The original patterns used zero-width lookaheads (
(?=[\s\S]*...)) anchored at the same position, so all tokens were asserted to exist anywhere in the content regardless of order. The new patterns are sequential — each[\s\S]{0,N}span must follow the previous token in source order. For the three affected checks (redacted product trust audit records,Cloud provision restart reopened view,signed provenance trust policy) this is a semantic change: if the target test file has the required tokens in a different order than the new regex expects, the check will spuriously report an audit failure. Worth verifying the token order in the actual test file matches the new sequence before relying on these patterns in CI.Reviews (15): Last reviewed commit: "Merge remote-tracking branch 'origin/dev..." | Re-trigger Greptile