Skip to content

fix(test): allowlist known service type migrations#7880

Merged
lalalune merged 1 commit into
developfrom
codex/ci-capability-router-followups
May 22, 2026
Merged

fix(test): allowlist known service type migrations#7880
lalalune merged 1 commit into
developfrom
codex/ci-capability-router-followups

Conversation

@NubsCarson
Copy link
Copy Markdown
Member

@NubsCarson NubsCarson commented May 21, 2026

Summary

  • allowlist the current capability-router service type migration while RuntimeCapabilityService coexists with the legacy remote/E2B routers
  • allowlist the xr-session duplicate while Hearwear and XR provide alternative implementations of the same session contract
  • remove duplicate app-core Vitest aliases introduced by the landed Windows desktop packaging patch so the release contract suite can load its config
  • align the dflash fused-target test with the script contract: desktop/server fused targets are advertised, while mobile fused targets fail closed with explicit diagnostics

Verification

  • node packages/scripts/run-vitest.mjs run --config packages/core/vitest.config.ts packages/core/src/__tests__/service-type-collisions.test.ts
  • node packages/scripts/run-vitest.mjs run --config packages/app-core/vitest.config.ts packages/app-core/platforms/electrobun/src/electrobun-config.test.ts
  • direct build-llama-cpp-dflash.mjs import check for fused help output and unsupported mobile fused diagnostics
  • node ../../packages/scripts/run-vitest.mjs run --config vitest.config.ts src/actions/enter-worktree.test.ts src/actions/exit-worktree.test.ts src/actions/ls.test.ts src/actions/read.test.ts src/actions/write.test.ts src/lib/run-shell.test.ts from plugins/plugin-coding-tools

Greptile Summary

This PR unblocks three test suites that were failing due to legitimate code-state mismatches rather than actual bugs. All changes are test/config fixes with no production logic touched.

  • service-type-collisions.test.ts: Adds capability-router (3 classes: RuntimeCapabilityService, E2BRemoteCapabilityRouterService, RemoteCapabilityRouterService) and xr-session (2 classes: Hearwear and XR XRSessionService) to the duplicate allowlist. All referenced paths and service-type string values were verified against the live source files.
  • vitest.config.ts: Removes a duplicate variable declaration and alias pair for @elizaos/plugin-worker-runtime that were introduced by the Windows desktop packaging patch; an identical definition already exists later in the file, so resolution is unaffected.
  • build-llama-cpp-dflash-targets.test.mjs: Aligns help-text assertions with the actual SUPPORTED_TARGETS / FUSED_TARGETS arrays — replaces the incorrect ios-arm64-metal-fused match with darwin-arm64-metal-fused, moves iOS fused variants to doesNotMatch, and adds them to the fail-closed error-message cases.

Confidence Score: 5/5

Safe to merge — all changes are test and config corrections with no production logic modified.

Every allowlist class path and service-type string was cross-checked against the live source. The vitest alias removal is non-breaking because an identical alias survives lower in the file. The build-script test corrections precisely match the actual SUPPORTED_TARGETS and fail-closed map in the build script.

No files require special attention.

Important Files Changed

Filename Overview
packages/core/src/tests/service-type-collisions.test.ts Adds two well-justified allowlist entries (capability-router and xr-session) for known in-flight service-type migrations; all referenced class paths and service type string values verified against existing source files.
packages/app-core/vitest.config.ts Removes a duplicate @elizaos/plugin-worker-runtime variable declaration and its corresponding alias entries; an identical declaration and pair of aliases remain lower in the file, so nothing breaks.
packages/app-core/scripts/build-llama-cpp-dflash-targets.test.mjs Corrects help-text assertions to match actual SUPPORTED_TARGETS/FUSED_TARGETS arrays: replaces wrong ios-arm64-metal-fused match with darwin-arm64-metal-fused, moves iOS fused variants to doesNotMatch, and adds them to the fail-closed error-message test cases.

Reviews (3): Last reviewed commit: "fix(test): allowlist known service type ..." | Re-trigger Greptile

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 21, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c9bf3f48-d3d6-4937-aaca-00d7552f6999

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/ci-capability-router-followups

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added the Tests label May 21, 2026
@claude
Copy link
Copy Markdown
Contributor

claude Bot commented May 21, 2026

Claude encountered an error —— View job


I'll analyze this and get back to you.

@NubsCarson NubsCarson force-pushed the codex/ci-capability-router-followups branch from 26f3787 to 8ac7938 Compare May 21, 2026 07:08
@claude
Copy link
Copy Markdown
Contributor

claude Bot commented May 21, 2026

Claude encountered an error —— View job


I'll analyze this and get back to you.

@NubsCarson NubsCarson force-pushed the codex/ci-capability-router-followups branch from 8ac7938 to ff890cc Compare May 21, 2026 07:22
@github-actions github-actions Bot added the build label May 21, 2026
@claude
Copy link
Copy Markdown
Contributor

claude Bot commented May 21, 2026

Claude encountered an error —— View job


I'll analyze this and get back to you.

@NubsCarson
Copy link
Copy Markdown
Member Author

Status refresh (2026-05-22): this PR is still mergeable and the refreshed checks are green.

Current check state from gh pr checks:

  • check-pr-title: pass
  • Server Tests: pass
  • Plugin Tests: pass
  • Android Debug Build: pass
  • iOS Simulator Build: pass
  • packaging/tarball/PyPI lanes: pass
  • CodeRabbit/CodeFactor/security/format/homepage/env audit: pass

No source changes needed from my side; this looks ready for maintainer review/merge.

@lalalune lalalune merged commit f990a89 into develop May 22, 2026
38 of 39 checks passed
@lalalune lalalune deleted the codex/ci-capability-router-followups branch May 22, 2026 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants