fix(test): allowlist known service type migrations#7880
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
26f3787 to
8ac7938
Compare
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
8ac7938 to
ff890cc
Compare
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
|
Status refresh (2026-05-22): this PR is still mergeable and the refreshed checks are green. Current check state from
No source changes needed from my side; this looks ready for maintainer review/merge. |
Summary
capability-routerservice type migration whileRuntimeCapabilityServicecoexists with the legacy remote/E2B routersxr-sessionduplicate while Hearwear and XR provide alternative implementations of the same session contractVerification
node packages/scripts/run-vitest.mjs run --config packages/core/vitest.config.ts packages/core/src/__tests__/service-type-collisions.test.tsnode packages/scripts/run-vitest.mjs run --config packages/app-core/vitest.config.ts packages/app-core/platforms/electrobun/src/electrobun-config.test.tsbuild-llama-cpp-dflash.mjsimport check for fused help output and unsupported mobile fused diagnosticsnode ../../packages/scripts/run-vitest.mjs run --config vitest.config.ts src/actions/enter-worktree.test.ts src/actions/exit-worktree.test.ts src/actions/ls.test.ts src/actions/read.test.ts src/actions/write.test.ts src/lib/run-shell.test.tsfromplugins/plugin-coding-toolsGreptile Summary
This PR unblocks three test suites that were failing due to legitimate code-state mismatches rather than actual bugs. All changes are test/config fixes with no production logic touched.
service-type-collisions.test.ts: Addscapability-router(3 classes:RuntimeCapabilityService,E2BRemoteCapabilityRouterService,RemoteCapabilityRouterService) andxr-session(2 classes: Hearwear and XRXRSessionService) to the duplicate allowlist. All referenced paths and service-type string values were verified against the live source files.vitest.config.ts: Removes a duplicate variable declaration and alias pair for@elizaos/plugin-worker-runtimethat were introduced by the Windows desktop packaging patch; an identical definition already exists later in the file, so resolution is unaffected.build-llama-cpp-dflash-targets.test.mjs: Aligns help-text assertions with the actualSUPPORTED_TARGETS/FUSED_TARGETSarrays — replaces the incorrectios-arm64-metal-fusedmatch withdarwin-arm64-metal-fused, moves iOS fused variants todoesNotMatch, and adds them to the fail-closed error-message cases.Confidence Score: 5/5
Safe to merge — all changes are test and config corrections with no production logic modified.
Every allowlist class path and service-type string was cross-checked against the live source. The vitest alias removal is non-breaking because an identical alias survives lower in the file. The build-script test corrections precisely match the actual SUPPORTED_TARGETS and fail-closed map in the build script.
No files require special attention.
Important Files Changed
Reviews (3): Last reviewed commit: "fix(test): allowlist known service type ..." | Re-trigger Greptile