Translate readme#28
Merged
Merged
Conversation
54f03b4 to
cb81228
Compare
the idea is for it to be possible for a family member to share your keys over the phone
cb81228 to
909e619
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces full support for multilingual recovery bundles, allowing each friend to receive their bundle in their preferred language. The changes span documentation, backend bundle generation, and end-to-end test updates to ensure compatibility with translated filenames and content. The most important changes are grouped below:
Multilingual Bundle Support
docs/guide.md) [1] [2]internal/bundle/bundle.goto select the correct language per friend, propagate language to all bundle files, and generate translated filenames for README.txt and README.pdf. (internal/bundle/bundle.go) [1] [2] [3] [4] [5] [6] [7] [8]Test Infrastructure Updates
e2e/helpers.ts) [1] [2]README.txt. (e2e/recovery.spec.ts,e2e/qr-scanner.spec.ts) [1] [2] [3] [4] [5] [6] [7] [8] [9]Translation-Aware Extraction
e2e/helpers.ts)UI Translation Updates
e2e/creation.spec.ts)Codebase Integration
translationsmodule to bundle generation and README logic, enabling translation-aware file creation and verification. (internal/bundle/bundle.go,internal/bundle/readme.go) [1] [2]This also translates the BIP39 lists, so they can actually be said over the phone. It uses official translations too whenever possible.
Fixes #10