Skip to content

Fix CPPCheck issue of type performance::passedByValue #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 5, 2025
Merged

Fix CPPCheck issue of type performance::passedByValue #101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
08bd386
Issue fix list
eljonny Mar 5, 2025
c4c983b
Fixes #8 (again) by making reason parameter const.
eljonny Mar 5, 2025
fb82d08
Resolves issue, remove issue list.
eljonny Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/internal/TestCPPTestCase.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,7 @@ namespace TestCPP {
* @param failureMessage The error message from the test that
* should be logged.
*/
void logTestFailure (string failureMessage);
void logTestFailure (const string& failureMessage);
/**
* @brief Internal test run controller.
*/
Expand Down
2 changes: 1 addition & 1 deletion src/TestCPPTestCase.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,7 @@ namespace TestCPP {
out << TCPPStr::REASON_ << reason << endl;
}

void TestCase::logTestFailure (string reason) {
void TestCase::logTestFailure (const string& reason) {
unique_ptr<ostream> logStream = nullptr;

if (this->clogOriginal.get() != nullptr) {
Expand Down