Add cmake presets

[eljonny]

Closes #16

[github-actions]

⚡ Static analysis result ⚡

🔴 cppcheck found 20 issues! Click here to see details.

TestCPP/include/internal/TestCPPAssertions.h

Lines 78 to 83 in ac88b62

	string failureMessage = "Arguments are not equivalent!"
	)
	{
	if (expected != actual) {
	stringstream err;

!Line: 78 - performance: Function parameter 'failureMessage' should be passed by const reference. [passedByValue]

TestCPP/include/internal/TestCPPAssertions.h

Lines 109 to 114 in ac88b62

	string failureMessage = "Arguments are equivalent!"
	)
	{
	if (expected == actual) {
	stringstream err;

!Line: 109 - performance: Function parameter 'failureMessage' should be passed by const reference. [passedByValue]

TestCPP/include/internal/TestCPPAssertions.h

Lines 136 to 141 in ac88b62

	string failureMessage = "Object is not null!"
	)
	{
	bool null = ptr == nullptr;
	if (!null) {

!Line: 136 - performance: Function parameter 'failureMessage' should be passed by const reference. [passedByValue]

TestCPP/include/internal/TestCPPAssertions.h

Lines 163 to 168 in ac88b62

	string failureMessage = "Object is null!"
	)
	{
	bool notNull = ptr != nullptr;
	if (!notNull) {

!Line: 163 - performance: Function parameter 'failureMessage' should be passed by const reference. [passedByValue]

TestCPP/src/TestCPPAssertions.cpp

Lines 92 to 97 in ac88b62

	string failureMessage
	)
	{
	if (!condition) {
	stringstream err;

!Line: 92 - performance: Function parameter 'failureMessage' should be passed by const reference. [passedByValue]

TestCPP/src/TestCPPAssertions.cpp

Lines 107 to 112 in ac88b62

	string failureMessage
	)
	{
	if (condition) {
	stringstream err;

!Line: 107 - performance: Function parameter 'failureMessage' should be passed by const reference. [passedByValue]

TestCPP/src/TestCPPTestCase.cpp

Lines 171 to 176 in ac88b62

	this->outCompareOption(std::move(o.option));
	this->setNotifyPassed(std::move(o.notifyTestPassed));
	this->pass = std::move(o.pass);
	this->lastRunTime = std::move(o.lastRunTime);

!Line: 171 - error: Exception thrown in function declared not to throw exceptions. [throwInNoexceptFunction]

TestCPP/src/TestCPPTestCase.cpp

Lines 262 to 267 in ac88b62

	this->outCompareOption(std::move(rhs.option));
	this->setNotifyPassed(std::move(rhs.notifyTestPassed));
	this->pass = std::move(rhs.pass);
	this->lastRunTime = std::move(rhs.lastRunTime);

!Line: 262 - error: Exception thrown in function declared not to throw exceptions. [throwInNoexceptFunction]

TestCPP/src/TestCPPTestCase.cpp

Lines 479 to 484 in ac88b62

	bool TestCase::checkStdout (string against) {
	return checkOutput(TestCase::stdoutBuffer.get()->str(),
	against);
	}
	bool TestCase::checkLog (string against) {

!Line: 479 - performance: Function parameter 'against' should be passed by const reference. [passedByValue]

TestCPP/src/TestCPPTestCase.cpp

Lines 484 to 489 in ac88b62

	bool TestCase::checkLog (string against) {
	return checkOutput(TestCase::clogBuffer.get()->str(),
	against);
	}
	bool TestCase::checkStderr (string against) {

!Line: 484 - performance: Function parameter 'against' should be passed by const reference. [passedByValue]

TestCPP/src/TestCPPTestCase.cpp

Lines 489 to 494 in ac88b62

	bool TestCase::checkStderr (string against) {
	return checkOutput(TestCase::stderrBuffer.get()->str(),
	against);
	}
	bool TestCase::checkOutput (string source, string against)

!Line: 489 - performance: Function parameter 'against' should be passed by const reference. [passedByValue]

TestCPP/src/TestCPPTestCase.cpp

Lines 494 to 499 in ac88b62

	bool TestCase::checkOutput (string source, string against)
	{
	switch (this->option) {
	case EXACT:
	if (source == against) {
	return true;

!Line: 494 - performance: Function parameter 'source' should be passed by const reference. [passedByValue]

TestCPP/src/TestCPPTestCase.cpp

Lines 494 to 499 in ac88b62

	bool TestCase::checkOutput (string source, string against)
	{
	switch (this->option) {
	case EXACT:
	if (source == against) {
	return true;

!Line: 494 - performance: Function parameter 'against' should be passed by const reference. [passedByValue]

TestCPP/src/TestCPPTestCase.cpp

Lines 145 to 150 in ac88b62

	TestCase::TestCase (TestCase& o) {
	this->outCompareOption(o.option);
	this->setNotifyPassed(o.notifyTestPassed);
	this->pass = o.pass;
	this->lastRunTime = o.lastRunTime;

!Line: 145 - style: Parameter 'o' can be declared as reference to const [constParameterReference]

TestCPP/src/TestCPPTestCase.cpp

Lines 234 to 239 in ac88b62

	TestCase& TestCase::operator= (TestCase& rhs) {
	this->outCompareOption(rhs.option);
	this->setNotifyPassed(rhs.notifyTestPassed);
	this->pass = rhs.pass;
	this->lastRunTime = rhs.lastRunTime;

!Line: 234 - style: Parameter 'rhs' can be declared as reference to const [constParameterReference]

TestCPP/src/TestCPPTestCase.cpp

Lines 292 to 297 in ac88b62

	void TestCase::logFailure(ostream& out, string& reason) {
	out << fixed;
	out << setprecision(TCPPNum::TIME_PRECISION);
	out << TCPPStr::TEST << this->testName << TCPPStr::FAIL
	<< TCPPStr::PARENL
	<< static_cast<double>(this->lastRunTime)/

!Line: 292 - style: Parameter 'reason' can be declared as reference to const [constParameterReference]

TestCPP/include/internal/TestCPPTestSuite.h

Lines 80 to 85 in ac88b62

	TestSuite (TestObjName&& suiteName,
	typename enable_if<sizeof...(TestType) == 0>::type)
	{
	this->testSuitePassedMessage = true;
	this->setSuiteName(std::move(suiteName));
	this->tests = vector<TestCase>();

!Line: 80 - warning: Member variable 'TestSuite::lastRunSucceeded' is not initialized in the constructor. [uninitMemberVar]

TestCPP/include/internal/TestCPPTestSuite.h

Lines 80 to 85 in ac88b62

	TestSuite (TestObjName&& suiteName,
	typename enable_if<sizeof...(TestType) == 0>::type)
	{
	this->testSuitePassedMessage = true;
	this->setSuiteName(std::move(suiteName));
	this->tests = vector<TestCase>();

!Line: 80 - warning: Member variable 'TestSuite::lastRunSuccessCount' is not initialized in the constructor. [uninitMemberVar]

TestCPP/include/internal/TestCPPTestSuite.h

Lines 80 to 85 in ac88b62

	TestSuite (TestObjName&& suiteName,
	typename enable_if<sizeof...(TestType) == 0>::type)
	{
	this->testSuitePassedMessage = true;
	this->setSuiteName(std::move(suiteName));
	this->tests = vector<TestCase>();

!Line: 80 - warning: Member variable 'TestSuite::lastRunFailCount' is not initialized in the constructor. [uninitMemberVar]

TestCPP/include/internal/TestCPPTestSuite.h

Lines 80 to 85 in ac88b62

	TestSuite (TestObjName&& suiteName,
	typename enable_if<sizeof...(TestType) == 0>::type)
	{
	this->testSuitePassedMessage = true;
	this->setSuiteName(std::move(suiteName));
	this->tests = vector<TestCase>();

!Line: 80 - warning: Member variable 'TestSuite::totalRuntime' is not initialized in the constructor. [uninitMemberVar]

---

🔴 clang-tidy found 157 issues! Click here to see details.

TestCPP/.clang-tidy

Lines 4 to 9 in ac88b62

	"ExcludeHeaderFilterRegex": "boost/.*",
	"WarningsAsErrors": "*",
	"FormatStyle": "none",
	"SystemHeaders": false,
	"ExtraArgs": [
	"-Iinclude",

!Line: 4 - error: unknown key 'ExcludeHeaderFilterRegex'

TestCPP/src/TestCPPExceptions.cpp

Lines 36 to 41 in ac88b62

	using std::clog;
	using std::string;
	using std::runtime_error;
	namespace TestCPP {

!Line: 36 - warning: using decl 'clog' is unused [misc-unused-using-decls]

!Line: 36 - note: remove the using

TestCPP/src/TestCPPExceptions.cpp

Lines 37 to 42 in ac88b62

	using std::string;
	using std::runtime_error;
	namespace TestCPP {
	TestCPPException::TestCPPException (const char * msg) :

!Line: 37 - warning: no header providing "std::string" is directly included [misc-include-cleaner]

TestCPP/src/TestCPPExceptions.cpp

Lines 38 to 43 in ac88b62

	using std::runtime_error;
	namespace TestCPP {
	TestCPPException::TestCPPException (const char * msg) :
	runtime_error(msg)

!Line: 38 - warning: no header providing "std::runtime_error" is directly included [misc-include-cleaner]

TestCPP/src/TestCPPExceptions.cpp

Lines 50 to 55 in ac88b62

	runtime_error(std::move(msg))
	{
	#ifdef TESTCPP_STACKTRACE_ENABLED
	clog << boost::stacktrace::stacktrace();
	#endif
	}

!Line: 50 - warning: passing result of std::move() as a const reference argument; no move will actually happen [hicpp-move-const-arg,performance-move-const-arg]

TestCPP/src/TestCPPExceptions.cpp

Lines 50 to 55 in ac88b62

	runtime_error(std::move(msg))
	{
	#ifdef TESTCPP_STACKTRACE_ENABLED
	clog << boost::stacktrace::stacktrace();
	#endif
	}

!Line: 50 - warning: no header providing "std::move" is directly included [misc-include-cleaner]

TestCPP/src/TestCPPAssertions.cpp

Lines 30 to 35 in ac88b62

	using std::clog;
	using std::current_exception;
	using std::endl;
	using std::exception;
	using std::exception_ptr;
	using std::function;

!Line: 30 - warning: no header providing "std::clog" is directly included [misc-include-cleaner]

TestCPP/src/TestCPPAssertions.cpp

Lines 31 to 36 in ac88b62

	using std::current_exception;
	using std::endl;
	using std::exception;
	using std::exception_ptr;
	using std::function;
	using std::rethrow_exception;

!Line: 31 - warning: no header providing "std::current_exception" is directly included [misc-include-cleaner]

TestCPP/src/TestCPPAssertions.cpp

Lines 33 to 38 in ac88b62

	using std::exception;
	using std::exception_ptr;
	using std::function;
	using std::rethrow_exception;
	using std::string;
	using std::stringstream;

!Line: 33 - warning: no header providing "std::exception" is directly included [misc-include-cleaner]

TestCPP/src/TestCPPAssertions.cpp

Lines 34 to 39 in ac88b62

	using std::exception_ptr;
	using std::function;
	using std::rethrow_exception;
	using std::string;
	using std::stringstream;

!Line: 34 - warning: no header providing "std::__exception_ptr::exception_ptr" is directly included [misc-include-cleaner]

TestCPP/src/TestCPPAssertions.cpp

Lines 36 to 41 in ac88b62

	using std::rethrow_exception;
	using std::string;
	using std::stringstream;
	namespace TestCPP {

!Line: 36 - warning: no header providing "std::rethrow_exception" is directly included [misc-include-cleaner]

TestCPP/src/TestCPPAssertions.cpp

Lines 37 to 42 in ac88b62

	using std::string;
	using std::stringstream;
	namespace TestCPP {
	void Assertions::assertThrows (

!Line: 37 - warning: no header providing "std::string" is directly included [misc-include-cleaner]

TestCPP/src/TestCPPAssertions.cpp

Lines 38 to 43 in ac88b62

	using std::stringstream;
	namespace TestCPP {
	void Assertions::assertThrows (
	function<void()> shouldThrow,

!Line: 38 - warning: no header providing "std::stringstream" is directly included [misc-include-cleaner]

TestCPP/src/TestCPPAssertions.cpp

Lines 43 to 48 in ac88b62

	function<void()> shouldThrow,
	string failureMessage
	)
	{
	try {
	shouldThrow();

!Line: 43 - warning: the parameter 'shouldThrow' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]

TestCPP/src/TestCPPAssertions.cpp

Lines 51 to 56 in ac88b62

	exception_ptr eptr = current_exception();
	if (eptr) {
	try {
	rethrow_exception(eptr);
	}

!Line: 51 - warning: variable 'eptr' of type 'exception_ptr' can be declared 'const' [misc-const-correctness]

TestCPP/src/TestCPPAssertions.cpp

Lines 60 to 65 in ac88b62

	<< endl;
	}
	}
	else {
	clog << "Something was thrown, not sure what." << endl
	<< "This satisfies the assertion, so no failure is"

!Line: 60 - warning: do not use 'endl' with streams; use '\n' instead [performance-avoid-endl]

TestCPP/src/TestCPPAssertions.cpp

Lines 64 to 69 in ac88b62

	clog << "Something was thrown, not sure what." << endl
	<< "This satisfies the assertion, so no failure is"
	<< " present. "
	<< TestFailedException("Unknown thrown object").
	what();
	}

!Line: 64 - warning: do not use 'endl' with streams; use '\n' instead [performance-avoid-endl]

TestCPP/src/TestCPPAssertions.cpp

Lines 74 to 79 in ac88b62

	throw TestFailedException(std::move(failureMessage));
	}
	void Assertions::assertNoThrows (
	function<void()> shouldNotThrow,
	string failureMessage

!Line: 74 - warning: no header providing "std::move" is directly included [misc-include-cleaner]

TestCPP/src/TestCPPAssertions.cpp

Lines 78 to 83 in ac88b62

	function<void()> shouldNotThrow,
	string failureMessage
	)
	{
	try {
	shouldNotThrow();

!Line: 78 - warning: the parameter 'shouldNotThrow' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]

TestCPP/src/TestCPPAssertions.cpp

Lines 92 to 97 in ac88b62

	string failureMessage
	)
	{
	if (!condition) {
	stringstream err;

!Line: 92 - warning: the parameter 'failureMessage' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]

TestCPP/src/TestCPPAssertions.cpp

Lines 98 to 103 in ac88b62

	err << "Boolean Truth assertion failed!" << endl;
	err << failureMessage << endl;
	throw TestFailedException(err.str());
	}
	}

!Line: 98 - warning: do not use 'endl' with streams; use '\n' instead [performance-avoid-endl]

TestCPP/src/TestCPPAssertions.cpp

Lines 99 to 104 in ac88b62

	err << failureMessage << endl;
	throw TestFailedException(err.str());
	}
	}

!Line: 99 - warning: do not use 'endl' with streams; use '\n' instead [performance-avoid-endl]

TestCPP/src/TestCPPAssertions.cpp

Lines 107 to 112 in ac88b62

	string failureMessage
	)
	{
	if (condition) {
	stringstream err;

!Line: 107 - warning: the parameter 'failureMessage' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]

TestCPP/src/TestCPPAssertions.cpp

Lines 113 to 118 in ac88b62

	err << "Boolean False assertion failed!" << endl;
	err << failureMessage << endl;
	throw TestFailedException(err.str());
	}
	}

!Line: 113 - warning: do not use 'endl' with streams; use '\n' instead [performance-avoid-endl]

TestCPP/src/TestCPPAssertions.cpp

Lines 114 to 119 in ac88b62

	err << failureMessage << endl;
	throw TestFailedException(err.str());
	}
	}

!Line: 114 - warning: do not use 'endl' with streams; use '\n' instead [performance-avoid-endl]

TestCPP/src/TestCPPUtil.cpp

Lines 51 to 56 in ac88b62

	if (name) {
	this->testCaseName = name;
	}
	else {
	throw TestCPPException(TCPPStr::NVTN);
	}

!Line: 51 - warning: implicit conversion 'const char *' -> 'bool' [readability-implicit-bool-conversion]

TestCPP/src/TestCPPUtil.cpp

Lines 59 to 64 in ac88b62

	const string& TestObjName::getName () {
	return this->testCaseName;
	}
	std::ostream& operator<< (
	std::ostream& s,

!Line: 59 - warning: use a trailing return type for this function [modernize-use-trailing-return-type]

TestCPP/src/TestCPPUtil.cpp

Lines 63 to 68 in ac88b62

	std::ostream& operator<< (
	std::ostream& s,
	TestObjName& tcName
	)
	{
	s << tcName.getName();

!Line: 63 - warning: use a trailing return type for this function [modernize-use-trailing-return-type]

TestCPP/src/TestCPPUtil.cpp

Lines 64 to 69 in ac88b62

	std::ostream& s,
	TestObjName& tcName
	)
	{
	s << tcName.getName();
	return s;

!Line: 64 - warning: parameter name 's' is too short, expected at least 3 characters [readability-identifier-length]

TestCPP/src/TestCPPUtil.cpp

Lines 78 to 83 in ac88b62

	clog << endl;
	}
	#endif
	}
	bool stringContains(const string& source,

!Line: 78 - warning: do not use 'endl' with streams; use '\n' instead [performance-avoid-endl]

TestCPP/src/TestCPPUtil.cpp

Lines 83 to 88 in ac88b62

	bool stringContains(const string& source,
	const string& contains)
	{
	return source.find(contains) != string::npos;
	}

!Line: 83 - warning: use a trailing return type for this function [modernize-use-trailing-return-type]

TestCPP/src/TestCPPUtil.cpp

Lines 89 to 94 in ac88b62

	int unsignedToSigned(unsigned toCast) {
	if (toCast <= INT_MAX) {
	return static_cast<int>(toCast);
	}
	if (toCast >= static_cast<unsigned>(INT_MIN)) {

!Line: 89 - warning: use a trailing return type for this function [modernize-use-trailing-return-type]

TestCPP/src/TestCPPTestSuite.cpp

Lines 36 to 41 in ac88b62

	using std::cerr;
	using std::clog;
	using std::cout;
	using std::endl;
	using std::exception;
	using std::fixed;

!Line: 36 - warning: no header providing "std::cerr" is directly included [misc-include-cleaner]

TestCPP/src/TestCPPTestSuite.cpp

Lines 37 to 42 in ac88b62

	using std::clog;
	using std::cout;
	using std::endl;
	using std::exception;
	using std::fixed;
	using std::function;

!Line: 37 - warning: no header providing "std::clog" is directly included [misc-include-cleaner]

TestCPP/src/TestCPPTestSuite.cpp

Lines 38 to 43 in ac88b62

	using std::cout;
	using std::endl;
	using std::exception;
	using std::fixed;
	using std::function;
	using std::invalid_argument;

!Line: 38 - warning: using decl 'cout' is unused [misc-unused-using-decls]

!Line: 38 - note: remove the using

TestCPP/src/TestCPPTestSuite.cpp

Lines 40 to 45 in ac88b62

	using std::exception;
	using std::fixed;
	using std::function;
	using std::invalid_argument;
	using std::ostream;
	using std::rethrow_exception;

!Line: 40 - warning: no header providing "std::exception" is directly included [misc-include-cleaner]

TestCPP/src/TestCPPTestSuite.cpp

Lines 41 to 46 in ac88b62

	using std::fixed;
	using std::function;
	using std::invalid_argument;
	using std::ostream;
	using std::rethrow_exception;
	using std::runtime_error;

!Line: 41 - warning: no header providing "std::fixed" is directly included [misc-include-cleaner]

TestCPP/src/TestCPPTestSuite.cpp

Lines 43 to 48 in ac88b62

	using std::invalid_argument;
	using std::ostream;
	using std::rethrow_exception;
	using std::runtime_error;
	using std::setprecision;
	using std::string;

!Line: 43 - warning: using decl 'invalid_argument' is unused [misc-unused-using-decls]

!Line: 43 - note: remove the using

TestCPP/src/TestCPPTestSuite.cpp

Lines 44 to 49 in ac88b62

	using std::ostream;
	using std::rethrow_exception;
	using std::runtime_error;
	using std::setprecision;
	using std::string;
	using std::tuple;

!Line: 44 - warning: no header providing "std::ostream" is directly included [misc-include-cleaner]

TestCPP/src/TestCPPTestSuite.cpp

Lines 45 to 50 in ac88b62

	using std::rethrow_exception;
	using std::runtime_error;
	using std::setprecision;
	using std::string;
	using std::tuple;

!Line: 45 - warning: no header providing "std::rethrow_exception" is directly included [misc-include-cleaner]

TestCPP/src/TestCPPTestSuite.cpp

Lines 45 to 50 in ac88b62

	using std::rethrow_exception;
	using std::runtime_error;
	using std::setprecision;
	using std::string;
	using std::tuple;

!Line: 45 - warning: using decl 'rethrow_exception' is unused [misc-unused-using-decls]

!Line: 45 - note: remove the using

TestCPP/src/TestCPPTestSuite.cpp

Lines 46 to 51 in ac88b62

	using std::runtime_error;
	using std::setprecision;
	using std::string;
	using std::tuple;
	using TCPPNum = TestCPP::TestCPPCommon::Nums;

!Line: 46 - warning: no header providing "std::runtime_error" is directly included [misc-include-cleaner]

TestCPP/src/TestCPPTestSuite.cpp

Lines 46 to 51 in ac88b62

	using std::runtime_error;
	using std::setprecision;
	using std::string;
	using std::tuple;
	using TCPPNum = TestCPP::TestCPPCommon::Nums;

!Line: 46 - warning: using decl 'runtime_error' is unused [misc-unused-using-decls]

!Line: 46 - note: remove the using

TestCPP/src/TestCPPTestSuite.cpp

Lines 48 to 53 in ac88b62

	using std::string;
	using std::tuple;
	using TCPPNum = TestCPP::TestCPPCommon::Nums;
	using TCPPStr = TestCPP::TestCPPCommon::Strings;

!Line: 48 - warning: no header providing "std::string" is directly included [misc-include-cleaner]

TestCPP/src/TestCPPTestSuite.cpp

Lines 69 to 74 in ac88b62

	void TestSuite::setSuiteName (TestObjName&& testSuiteName) {
	this->suiteName = std::move(testSuiteName);
	}
	unsigned TestSuite::getLastRunFailCount () {
	return this->lastRunFailCount;

!Line: 69 - warning: no header providing "TestCPP::TestObjName" is directly included [misc-include-cleaner]

TestCPP/src/TestCPPTestSuite.cpp

Lines 70 to 75 in ac88b62

	this->suiteName = std::move(testSuiteName);
	}
	unsigned TestSuite::getLastRunFailCount () {
	return this->lastRunFailCount;
	}

!Line: 70 - warning: no header providing "std::move" is directly included [misc-include-cleaner]

TestCPP/src/TestCPPTestSuite.cpp

Lines 73 to 78 in ac88b62

	unsigned TestSuite::getLastRunFailCount () {
	return this->lastRunFailCount;
	}
	void TestSuite::run () {
	if (this->tests.size() == 0) {

!Line: 73 - warning: use a trailing return type for this function [modernize-use-trailing-return-type]

TestCPP/src/TestCPPTestSuite.cpp

Lines 73 to 78 in ac88b62

	unsigned TestSuite::getLastRunFailCount () {
	return this->lastRunFailCount;
	}
	void TestSuite::run () {
	if (this->tests.size() == 0) {

!Line: 73 - warning: method 'getLastRunFailCount' can be made const [readability-make-member-function-const]

TestCPP/src/TestCPPTestSuite.cpp

Lines 78 to 83 in ac88b62

	if (this->tests.size() == 0) {
	clog << TCPPStr::NTR << endl;
	return;
	}
	this->lastRunSucceeded = true;

!Line: 78 - warning: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty]

TestCPP/src/TestCPPTestSuite.cpp

Lines 79 to 84 in ac88b62

	clog << TCPPStr::NTR << endl;
	return;
	}
	this->lastRunSucceeded = true;
	this->lastRunFailCount = 0;

!Line: 79 - warning: do not use 'endl' with streams; use '\n' instead [performance-avoid-endl]

TestCPP/src/TestCPPTestSuite.cpp

Lines 88 to 93 in ac88b62

	clog << endl
	<< TCPPStr::START_RUN << TCPPStr::SUITE
	<< TCPPStr::APOS << this->suiteName << TCPPStr::APOS
	<< endl
	<< endl;

!Line: 88 - warning: do not use 'endl' with streams; use '\n' instead [performance-avoid-endl]

TestCPP/src/TestCPPTestSuite.cpp

Lines 91 to 96 in ac88b62

	<< endl
	<< endl;
	for (TestCase test : this->tests) {
	bool testPassed = false;
	try {

!Line: 91 - warning: do not use 'endl' with streams; use '\n' instead [performance-avoid-endl]

TestCPP/src/TestCPPTestSuite.cpp

Lines 92 to 97 in ac88b62

	<< endl;
	for (TestCase test : this->tests) {
	bool testPassed = false;
	try {
	testPassed = test.go();

!Line: 92 - warning: do not use 'endl' with streams; use '\n' instead [performance-avoid-endl]

TestCPP/src/TestCPPTestSuite.cpp

Lines 101 to 106 in ac88b62

	<< endl;
	}
	catch (...) {
	cerr << TCPPStr::UNK_EXC
	<< endl;
	}

!Line: 101 - warning: do not use 'endl' with streams; use '\n' instead [performance-avoid-endl]

TestCPP/src/TestCPPTestSuite.cpp

Lines 105 to 110 in ac88b62

	<< endl;
	}
	if (!testPassed) {
	this->lastRunFailCount++;

!Line: 105 - warning: do not use 'endl' with streams; use '\n' instead [performance-avoid-endl]

TestCPP/src/TestCPPTestSuite.cpp

Lines 122 to 127 in ac88b62

	clog << endl;
	if (this->testSuitePassedMessage &&
	this->lastRunFailCount == 0) {
	clog << TCPPStr::ALL << TCPPStr::APOS << this->suiteName
	<< TCPPStr::APOS << TCPPStr::SUITE_TESTS_PASSED

!Line: 122 - warning: do not use 'endl' with streams; use '\n' instead [performance-avoid-endl]

TestCPP/src/TestCPPTestSuite.cpp

Lines 128 to 133 in ac88b62

	<< endl;
	}
	double suiteRuntimeElapsed = static_cast<double>(
	this->totalRuntime)/TCPPNum::NANOS_IN_SEC;

!Line: 128 - warning: do not use 'endl' with streams; use '\n' instead [performance-avoid-endl]

TestCPP/src/TestCPPTestSuite.cpp

Lines 131 to 136 in ac88b62

	double suiteRuntimeElapsed = static_cast<double>(
	this->totalRuntime)/TCPPNum::NANOS_IN_SEC;
	clog << fixed;
	clog << setprecision(0);
	clog << TCPPStr::FINISHED_SUITE << TCPPStr::APOS

!Line: 131 - warning: variable 'suiteRuntimeElapsed' of type 'double' can be declared 'const' [misc-const-correctness]

TestCPP/src/TestCPPTestSuite.cpp

Lines 142 to 147 in ac88b62

	<< endl;
	}
	/**
	* @brief Add a test to this test suite.
	*

!Line: 142 - warning: do not use 'endl' with streams; use '\n' instead [performance-avoid-endl]

TestCPP/src/TestCPPTestSuite.cpp

Lines 151 to 156 in ac88b62

	void TestSuite::addTest (TestCase&& test) {
	this->tests.emplace_back(test);
	}
	/**
	* @brief Add a test to this test suite.

!Line: 151 - warning: rvalue reference parameter 'test' is never moved from inside the function body [cppcoreguidelines-rvalue-reference-param-not-moved]

TestCPP/src/TestCPPTestSuite.cpp

Lines 164 to 169 in ac88b62

	function<void()>>&& test) {
	this->tests.emplace_back(
	std::get<0>(test),
	std::get<1>(test),
	this->testSuitePassedMessage
	);

!Line: 164 - warning: rvalue reference parameter 'test' is never moved from inside the function body [cppcoreguidelines-rvalue-reference-param-not-moved]

TestCPP/include/internal/TestCPPTestCase.h

Lines 131 to 136 in ac88b62

	TestCase (
	TestObjName&& testName,
	function<void()> test,
	bool testPassedMessage = true,
	bool captureOut = false,
	bool captureLog = false,

!Line: 131 - warning: function 'TestCPP::TestCase::TestCase' has a definition with different parameter names [readability-inconsistent-declaration-parameter-name]

!Line: 114 - note: the definition seen here
!Line: 131 - note: differing parameters are named here: ('testPassedMessage'), in definition: ('msg')

TestCPP/include/internal/TestCPPTestCase.h

Lines 299 to 304 in ac88b62

	void logTestFailure (string failureMessage);
	/**
	* @brief Internal test run controller.
	*/
	void runTest ();
	/**

!Line: 299 - warning: function 'TestCPP::TestCase::logTestFailure' has a definition with different parameter names [readability-inconsistent-declaration-parameter-name]

!Line: 304 - note: the definition seen here
!Line: 299 - note: differing parameters are named here: ('failureMessage'), in definition: ('reason')

TestCPP/src/TestCPPTestCase.cpp

Lines 45 to 50 in ac88b62

	using std::cerr;
	using std::clog;
	using std::cout;
	using std::endl;
	using std::exception;
	using std::fixed;

!Line: 45 - warning: no header providing "std::cerr" is directly included [misc-include-cleaner]

TestCPP/src/TestCPPTestCase.cpp

Lines 46 to 51 in ac88b62

	using std::clog;
	using std::cout;
	using std::endl;
	using std::exception;
	using std::fixed;
	using std::function;

!Line: 46 - warning: no header providing "std::clog" is directly included [misc-include-cleaner]

TestCPP/src/TestCPPTestCase.cpp

Lines 47 to 52 in ac88b62

	using std::cout;
	using std::endl;
	using std::exception;
	using std::fixed;
	using std::function;
	using std::invalid_argument;

!Line: 47 - warning: no header providing "std::cout" is directly included [misc-include-cleaner]

TestCPP/src/TestCPPTestCase.cpp

Lines 49 to 54 in ac88b62

	using std::exception;
	using std::fixed;
	using std::function;
	using std::invalid_argument;
	using std::rethrow_exception;
	using std::runtime_error;

!Line: 49 - warning: no header providing "std::exception" is directly included [misc-include-cleaner]

TestCPP/src/TestCPPTestCase.cpp

Lines 50 to 55 in ac88b62

	using std::fixed;
	using std::function;
	using std::invalid_argument;
	using std::rethrow_exception;
	using std::runtime_error;
	using std::setprecision;

!Line: 50 - warning: no header providing "std::fixed" is directly included [misc-include-cleaner]

TestCPP/src/TestCPPTestCase.cpp

Lines 52 to 57 in ac88b62

	using std::invalid_argument;
	using std::rethrow_exception;
	using std::runtime_error;
	using std::setprecision;
	using std::string;
	using std::tuple;

!Line: 52 - warning: using decl 'invalid_argument' is unused [misc-unused-using-decls]

!Line: 52 - note: remove the using

TestCPP/src/TestCPPTestCase.cpp

Lines 53 to 58 in ac88b62

	using std::rethrow_exception;
	using std::runtime_error;
	using std::setprecision;
	using std::string;
	using std::tuple;

!Line: 53 - warning: no header providing "std::rethrow_exception" is directly included [misc-include-cleaner]

TestCPP/src/TestCPPTestCase.cpp

Lines 53 to 58 in ac88b62

	using std::rethrow_exception;
	using std::runtime_error;
	using std::setprecision;
	using std::string;
	using std::tuple;

!Line: 53 - warning: using decl 'rethrow_exception' is unused [misc-unused-using-decls]

!Line: 53 - note: remove the using

TestCPP/src/TestCPPTestCase.cpp

Lines 54 to 59 in ac88b62

	using std::runtime_error;
	using std::setprecision;
	using std::string;
	using std::tuple;
	using TCPPNum = TestCPP::TestCPPCommon::Nums;

!Line: 54 - warning: no header providing "std::runtime_error" is directly included [misc-include-cleaner]

TestCPP/src/TestCPPTestCase.cpp

Lines 54 to 59 in ac88b62

	using std::runtime_error;
	using std::setprecision;
	using std::string;
	using std::tuple;
	using TCPPNum = TestCPP::TestCPPCommon::Nums;

!Line: 54 - warning: using decl 'runtime_error' is unused [misc-unused-using-decls]

!Line: 54 - note: remove the using

TestCPP/src/TestCPPTestCase.cpp

Lines 56 to 61 in ac88b62

	using std::string;
	using std::tuple;
	using TCPPNum = TestCPP::TestCPPCommon::Nums;
	using TCPPStr = TestCPP::TestCPPCommon::Strings;

!Line: 56 - warning: no header providing "std::string" is directly included [misc-include-cleaner]

TestCPP/src/TestCPPTestCase.cpp

Lines 57 to 62 in ac88b62

	using std::tuple;
	using TCPPNum = TestCPP::TestCPPCommon::Nums;
	using TCPPStr = TestCPP::TestCPPCommon::Strings;
	namespace TestCPP {

!Line: 57 - warning: using decl 'tuple' is unused [misc-unused-using-decls]

!Line: 57 - note: remove the using

TestCPP/src/TestCPPTestCase.cpp

Lines 64 to 69 in ac88b62

	atomic_int TestCase::stdoutCaptureCasesConstructed;
	atomic_int TestCase::logCaptureCasesConstructed;
	atomic_int TestCase::stderrCaptureCasesConstructed;
	atomic_int TestCase::stdoutCaptureCasesDestroyed;
	atomic_int TestCase::logCaptureCasesDestroyed;
	atomic_int TestCase::stderrCaptureCasesDestroyed;

!Line: 64 - warning: no header providing "atomic_int" is directly included [misc-include-cleaner]

TestCPP/src/TestCPPTestCase.cpp

Lines 72 to 77 in ac88b62

	TestCase::stdoutBuffer =
	no_destroy<unique_ptr<stringstream, void(*)(stringstream*)>>(
	unique_ptr<stringstream, void(*)(stringstream*)>(
	nullptr, [](stringstream*){}
	)
	);

!Line: 72 - warning: initialization of 'stdoutBuffer' with static storage duration may throw an exception that cannot be caught [cert-err58-cpp]

!Line: 109 - note: possibly throwing constructor declared here

TestCPP/src/TestCPPTestCase.cpp

Lines 79 to 84 in ac88b62

	TestCase::clogBuffer =
	no_destroy<unique_ptr<stringstream, void(*)(stringstream*)>>(
	unique_ptr<stringstream, void(*)(stringstream*)>(
	nullptr, [](stringstream*){}
	)
	);

!Line: 79 - warning: initialization of 'clogBuffer' with static storage duration may throw an exception that cannot be caught [cert-err58-cpp]

!Line: 109 - note: possibly throwing constructor declared here

TestCPP/src/TestCPPTestCase.cpp

Lines 86 to 91 in ac88b62

	TestCase::stderrBuffer =
	no_destroy<unique_ptr<stringstream, void(*)(stringstream*)>>(
	unique_ptr<stringstream, void(*)(stringstream*)>(
	nullptr, [](stringstream*){}
	)
	);

!Line: 86 - warning: initialization of 'stderrBuffer' with static storage duration may throw an exception that cannot be caught [cert-err58-cpp]

!Line: 109 - note: possibly throwing constructor declared here

TestCPP/src/TestCPPTestCase.cpp

Lines 93 to 98 in ac88b62

	TestCase::stdoutOriginal =
	no_destroy<unique_ptr<streambuf, void(*)(streambuf*)>>(
	unique_ptr<streambuf, void(*)(streambuf*)>(
	nullptr, [](streambuf*){}
	)
	);

!Line: 93 - warning: initialization of 'stdoutOriginal' with static storage duration may throw an exception that cannot be caught [cert-err58-cpp]

!Line: 109 - note: possibly throwing constructor declared here

TestCPP/src/TestCPPTestCase.cpp

Lines 100 to 105 in ac88b62

	TestCase::clogOriginal =
	no_destroy<unique_ptr<streambuf, void(*)(streambuf*)>>(
	unique_ptr<streambuf, void(*)(streambuf*)>(
	nullptr, [](streambuf*){}
	)
	);

!Line: 100 - warning: initialization of 'clogOriginal' with static storage duration may throw an exception that cannot be caught [cert-err58-cpp]

!Line: 109 - note: possibly throwing constructor declared here

TestCPP/src/TestCPPTestCase.cpp

Lines 107 to 112 in ac88b62

	TestCase::stderrOriginal =
	no_destroy<unique_ptr<streambuf, void(*)(streambuf*)>>(
	unique_ptr<streambuf, void(*)(streambuf*)>(
	nullptr, [](streambuf*){}
	)
	);

!Line: 107 - warning: initialization of 'stderrOriginal' with static storage duration may throw an exception that cannot be caught [cert-err58-cpp]

!Line: 109 - note: possibly throwing constructor declared here

TestCPP/src/TestCPPTestCase.cpp

Lines 114 to 119 in ac88b62

	TestCase::TestCase (TestObjName&& name,
	function<void()> testFn,
	bool msg,
	bool captureOut, bool captureLog,
	bool captureErr,
	TestCase::TestCaseOutCompareOptions opt)

!Line: 114 - warning: rvalue reference parameter 'name' is never moved from inside the function body [cppcoreguidelines-rvalue-reference-param-not-moved]

TestCPP/src/TestCPPTestCase.cpp

Lines 121 to 126 in ac88b62

	this->notifyTestPassed = msg;
	this->test = testFn;
	this->testName = name;
	if (captureOut) {

!Line: 121 - warning: 'notifyTestPassed' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer]

TestCPP/src/TestCPPTestCase.cpp

Lines 122 to 127 in ac88b62

	this->test = testFn;
	this->testName = name;
	if (captureOut) {
	captureStdout();

!Line: 122 - warning: 'test' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer]

TestCPP/src/TestCPPTestCase.cpp

Lines 122 to 127 in ac88b62

	this->test = testFn;
	this->testName = name;
	if (captureOut) {
	captureStdout();

!Line: 122 - warning: parameter 'testFn' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param]

TestCPP/src/TestCPPTestCase.cpp

Lines 124 to 129 in ac88b62

	this->testName = name;
	if (captureOut) {
	captureStdout();
	}
	if (captureLog) {

!Line: 124 - warning: 'testName' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer]

TestCPP/src/TestCPPTestCase.cpp

Lines 145 to 150 in ac88b62

	TestCase::TestCase (TestCase& o) {
	this->outCompareOption(o.option);
	this->setNotifyPassed(o.notifyTestPassed);
	this->pass = o.pass;
	this->lastRunTime = o.lastRunTime;

!Line: 145 - warning: parameter name 'o' is too short, expected at least 3 characters [readability-identifier-length]

TestCPP/src/TestCPPTestCase.cpp

Lines 149 to 154 in ac88b62

	this->pass = o.pass;
	this->lastRunTime = o.lastRunTime;
	this->stdoutCaptured = o.stdoutCaptured;
	this->clogCaptured = o.clogCaptured;
	this->stderrCaptured = o.stderrCaptured;

!Line: 149 - warning: 'pass' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer]

TestCPP/src/TestCPPTestCase.cpp

Lines 150 to 155 in ac88b62

	this->lastRunTime = o.lastRunTime;
	this->stdoutCaptured = o.stdoutCaptured;
	this->clogCaptured = o.clogCaptured;
	this->stderrCaptured = o.stderrCaptured;

!Line: 150 - warning: 'lastRunTime' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer]

TestCPP/src/TestCPPTestCase.cpp

Lines 152 to 157 in ac88b62

	this->stdoutCaptured = o.stdoutCaptured;
	this->clogCaptured = o.clogCaptured;
	this->stderrCaptured = o.stderrCaptured;
	if (this->stdoutCaptured) {
	captureStdout();

!Line: 152 - warning: 'stdoutCaptured' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer]

TestCPP/src/TestCPPTestCase.cpp

Lines 153 to 158 in ac88b62

	this->clogCaptured = o.clogCaptured;
	this->stderrCaptured = o.stderrCaptured;
	if (this->stdoutCaptured) {
	captureStdout();
	}

!Line: 153 - warning: 'clogCaptured' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer]

TestCPP/src/TestCPPTestCase.cpp

Lines 154 to 159 in ac88b62

	this->stderrCaptured = o.stderrCaptured;
	if (this->stdoutCaptured) {
	captureStdout();
	}
	if (this->clogCaptured) {

!Line: 154 - warning: 'stderrCaptured' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer]

TestCPP/src/TestCPPTestCase.cpp

Lines 170 to 175 in ac88b62

	TestCase::TestCase (TestCase&& o) noexcept {
	this->outCompareOption(std::move(o.option));
	this->setNotifyPassed(std::move(o.notifyTestPassed));
	this->pass = std::move(o.pass);
	this->lastRunTime = std::move(o.lastRunTime);

!Line: 170 - warning: an exception may be thrown in function 'TestCase' which should not throw exceptions [bugprone-exception-escape]

TestCPP/src/TestCPPTestCase.cpp

Lines 170 to 175 in ac88b62

	TestCase::TestCase (TestCase&& o) noexcept {
	this->outCompareOption(std::move(o.option));
	this->setNotifyPassed(std::move(o.notifyTestPassed));
	this->pass = std::move(o.pass);
	this->lastRunTime = std::move(o.lastRunTime);

!Line: 170 - warning: parameter name 'o' is too short, expected at least 3 characters [readability-identifier-length]

TestCPP/src/TestCPPTestCase.cpp

Lines 171 to 176 in ac88b62

	this->outCompareOption(std::move(o.option));
	this->setNotifyPassed(std::move(o.notifyTestPassed));
	this->pass = std::move(o.pass);
	this->lastRunTime = std::move(o.lastRunTime);

!Line: 171 - warning: std::move of the expression of the trivially-copyable type 'TestCaseOutCompareOptions' has no effect; remove std::move() [hicpp-move-const-arg,performance-move-const-arg]

TestCPP/src/TestCPPTestCase.cpp

Lines 171 to 176 in ac88b62

	this->outCompareOption(std::move(o.option));
	this->setNotifyPassed(std::move(o.notifyTestPassed));
	this->pass = std::move(o.pass);
	this->lastRunTime = std::move(o.lastRunTime);

!Line: 171 - warning: no header providing "std::move" is directly included [misc-include-cleaner]

TestCPP/src/TestCPPTestCase.cpp

Lines 172 to 177 in ac88b62

	this->setNotifyPassed(std::move(o.notifyTestPassed));
	this->pass = std::move(o.pass);
	this->lastRunTime = std::move(o.lastRunTime);
	this->stdoutCaptured = std::move(o.stdoutCaptured);

!Line: 172 - warning: std::move of the expression of the trivially-copyable type 'bool' has no effect; remove std::move() [hicpp-move-const-arg,performance-move-const-arg]

TestCPP/src/TestCPPTestCase.cpp

Lines 174 to 179 in ac88b62

	this->pass = std::move(o.pass);
	this->lastRunTime = std::move(o.lastRunTime);
	this->stdoutCaptured = std::move(o.stdoutCaptured);
	this->clogCaptured = std::move(o.clogCaptured);
	this->stderrCaptured = std::move(o.stderrCaptured);

!Line: 174 - warning: 'pass' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer]

TestCPP/src/TestCPPTestCase.cpp

Lines 174 to 179 in ac88b62

	this->pass = std::move(o.pass);
	this->lastRunTime = std::move(o.lastRunTime);
	this->stdoutCaptured = std::move(o.stdoutCaptured);
	this->clogCaptured = std::move(o.clogCaptured);
	this->stderrCaptured = std::move(o.stderrCaptured);

!Line: 174 - warning: std::move of the expression of the trivially-copyable type 'bool' has no effect; remove std::move() [hicpp-move-const-arg,performance-move-const-arg]

TestCPP/src/TestCPPTestCase.cpp

Lines 175 to 180 in ac88b62

	this->lastRunTime = std::move(o.lastRunTime);
	this->stdoutCaptured = std::move(o.stdoutCaptured);
	this->clogCaptured = std::move(o.clogCaptured);
	this->stderrCaptured = std::move(o.stderrCaptured);

!Line: 175 - warning: 'lastRunTime' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer]

TestCPP/src/TestCPPTestCase.cpp

Lines 175 to 180 in ac88b62

	this->lastRunTime = std::move(o.lastRunTime);
	this->stdoutCaptured = std::move(o.stdoutCaptured);
	this->clogCaptured = std::move(o.clogCaptured);
	this->stderrCaptured = std::move(o.stderrCaptured);

!Line: 175 - warning: std::move of the expression of the trivially-copyable type 'long long' has no effect; remove std::move() [hicpp-move-const-arg,performance-move-const-arg]

TestCPP/src/TestCPPTestCase.cpp

Lines 177 to 182 in ac88b62

	this->stdoutCaptured = std::move(o.stdoutCaptured);
	this->clogCaptured = std::move(o.clogCaptured);
	this->stderrCaptured = std::move(o.stderrCaptured);
	if (this->stdoutCaptured) {
	captureStdout();

!Line: 177 - warning: 'stdoutCaptured' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer]

TestCPP/src/TestCPPTestCase.cpp

Lines 177 to 182 in ac88b62

	this->stdoutCaptured = std::move(o.stdoutCaptured);
	this->clogCaptured = std::move(o.clogCaptured);
	this->stderrCaptured = std::move(o.stderrCaptured);
	if (this->stdoutCaptured) {
	captureStdout();

!Line: 177 - warning: std::move of the expression of the trivially-copyable type 'bool' has no effect; remove std::move() [hicpp-move-const-arg,performance-move-const-arg]

TestCPP/src/TestCPPTestCase.cpp

Lines 178 to 183 in ac88b62

	this->clogCaptured = std::move(o.clogCaptured);
	this->stderrCaptured = std::move(o.stderrCaptured);
	if (this->stdoutCaptured) {
	captureStdout();
	}

!Line: 178 - warning: 'clogCaptured' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer]

TestCPP/src/TestCPPTestCase.cpp

Lines 178 to 183 in ac88b62

	this->clogCaptured = std::move(o.clogCaptured);
	this->stderrCaptured = std::move(o.stderrCaptured);
	if (this->stdoutCaptured) {
	captureStdout();
	}

!Line: 178 - warning: std::move of the expression of the trivially-copyable type 'bool' has no effect; remove std::move() [hicpp-move-const-arg,performance-move-const-arg]

TestCPP/src/TestCPPTestCase.cpp

Lines 179 to 184 in ac88b62

	this->stderrCaptured = std::move(o.stderrCaptured);
	if (this->stdoutCaptured) {
	captureStdout();
	}
	if (this->clogCaptured) {

!Line: 179 - warning: 'stderrCaptured' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer]

TestCPP/src/TestCPPTestCase.cpp

Lines 179 to 184 in ac88b62

	this->stderrCaptured = std::move(o.stderrCaptured);
	if (this->stdoutCaptured) {
	captureStdout();
	}
	if (this->clogCaptured) {

!Line: 179 - warning: std::move of the expression of the trivially-copyable type 'bool' has no effect; remove std::move() [hicpp-move-const-arg,performance-move-const-arg]

TestCPP/src/TestCPPTestCase.cpp

Lines 202 to 207 in ac88b62

	delete TestCase::stdoutBuffer.get().get();
	TestCase::stdoutBuffer.get() = nullptr;
	}
	TestCase::stdoutCaptureCasesDestroyed += 1;
	}

!Line: 202 - warning: deleting a pointer through a type that is not marked 'gsl::owner<>'; consider using a smart pointer instead [cppcoreguidelines-owning-memory]

!Line: 71 - note: variable declared here

TestCPP/src/TestCPPTestCase.cpp

Lines 214 to 219 in ac88b62

	delete TestCase::clogBuffer.get().get();
	TestCase::clogBuffer.get() = nullptr;
	}
	TestCase::logCaptureCasesDestroyed += 1;
	}

!Line: 214 - warning: deleting a pointer through a type that is not marked 'gsl::owner<>'; consider using a smart pointer instead [cppcoreguidelines-owning-memory]

!Line: 78 - note: variable declared here

TestCPP/src/TestCPPTestCase.cpp

Lines 226 to 231 in ac88b62

	delete TestCase::stderrBuffer.get().get();
	TestCase::stderrBuffer.get() = nullptr;
	}
	TestCase::stderrCaptureCasesDestroyed += 1;
	}

!Line: 226 - warning: deleting a pointer through a type that is not marked 'gsl::owner<>'; consider using a smart pointer instead [cppcoreguidelines-owning-memory]

!Line: 85 - note: variable declared here

TestCPP/src/TestCPPTestCase.cpp

Lines 234 to 239 in ac88b62

	TestCase& TestCase::operator= (TestCase& rhs) {
	this->outCompareOption(rhs.option);
	this->setNotifyPassed(rhs.notifyTestPassed);
	this->pass = rhs.pass;
	this->lastRunTime = rhs.lastRunTime;

!Line: 234 - warning: operator=() should take 'TestCase const&', 'TestCase&&' or 'TestCase' [cppcoreguidelines-c-copy-assignment-signature,misc-unconventional-assign-operator]

TestCPP/src/TestCPPTestCase.cpp

Lines 234 to 239 in ac88b62

	TestCase& TestCase::operator= (TestCase& rhs) {
	this->outCompareOption(rhs.option);
	this->setNotifyPassed(rhs.notifyTestPassed);
	this->pass = rhs.pass;
	this->lastRunTime = rhs.lastRunTime;

!Line: 234 - warning: operator=() does not handle self-assignment properly [cert-oop54-cpp]

TestCPP/src/TestCPPTestCase.cpp

Lines 234 to 239 in ac88b62

	TestCase& TestCase::operator= (TestCase& rhs) {
	this->outCompareOption(rhs.option);
	this->setNotifyPassed(rhs.notifyTestPassed);
	this->pass = rhs.pass;
	this->lastRunTime = rhs.lastRunTime;

!Line: 234 - warning: use a trailing return type for this function [modernize-use-trailing-return-type]

TestCPP/src/TestCPPTestCase.cpp

Lines 261 to 266 in ac88b62

	TestCase& TestCase::operator= (TestCase&& rhs) noexcept {
	this->outCompareOption(std::move(rhs.option));
	this->setNotifyPassed(std::move(rhs.notifyTestPassed));
	this->pass = std::move(rhs.pass);
	this->lastRunTime = std::move(rhs.lastRunTime);

!Line: 261 - warning: an exception may be thrown in function 'operator=' which should not throw exceptions [bugprone-exception-escape]

TestCPP/src/TestCPPTestCase.cpp

Lines 261 to 266 in ac88b62

	TestCase& TestCase::operator= (TestCase&& rhs) noexcept {
	this->outCompareOption(std::move(rhs.option));
	this->setNotifyPassed(std::move(rhs.notifyTestPassed));
	this->pass = std::move(rhs.pass);
	this->lastRunTime = std::move(rhs.lastRunTime);

!Line: 261 - warning: use a trailing return type for this function [modernize-use-trailing-return-type]

TestCPP/src/TestCPPTestCase.cpp

Lines 262 to 267 in ac88b62

	this->outCompareOption(std::move(rhs.option));
	this->setNotifyPassed(std::move(rhs.notifyTestPassed));
	this->pass = std::move(rhs.pass);
	this->lastRunTime = std::move(rhs.lastRunTime);

!Line: 262 - warning: std::move of the expression of the trivially-copyable type 'TestCaseOutCompareOptions' has no effect; remove std::move() [hicpp-move-const-arg,performance-move-const-arg]

TestCPP/src/TestCPPTestCase.cpp

Lines 263 to 268 in ac88b62

	this->setNotifyPassed(std::move(rhs.notifyTestPassed));
	this->pass = std::move(rhs.pass);
	this->lastRunTime = std::move(rhs.lastRunTime);
	this->stdoutCaptured = std::move(rhs.stdoutCaptured);

!Line: 263 - warning: std::move of the expression of the trivially-copyable type 'bool' has no effect; remove std::move() [hicpp-move-const-arg,performance-move-const-arg]

TestCPP/src/TestCPPTestCase.cpp

Lines 265 to 270 in ac88b62

	this->pass = std::move(rhs.pass);
	this->lastRunTime = std::move(rhs.lastRunTime);
	this->stdoutCaptured = std::move(rhs.stdoutCaptured);
	this->clogCaptured = std::move(rhs.clogCaptured);
	this->stderrCaptured = std::move(rhs.stderrCaptured);

!Line: 265 - warning: std::move of the expression of the trivially-copyable type 'bool' has no effect; remove std::move() [hicpp-move-const-arg,performance-move-const-arg]

TestCPP/src/TestCPPTestCase.cpp

Lines 266 to 271 in ac88b62

	this->lastRunTime = std::move(rhs.lastRunTime);
	this->stdoutCaptured = std::move(rhs.stdoutCaptured);
	this->clogCaptured = std::move(rhs.clogCaptured);
	this->stderrCaptured = std::move(rhs.stderrCaptured);

!Line: 266 - warning: std::move of the expression of the trivially-copyable type 'long long' has no effect; remove std::move() [hicpp-move-const-arg,performance-move-const-arg]

TestCPP/src/TestCPPTestCase.cpp

Lines 268 to 273 in ac88b62

	this->stdoutCaptured = std::move(rhs.stdoutCaptured);
	this->clogCaptured = std::move(rhs.clogCaptured);
	this->stderrCaptured = std::move(rhs.stderrCaptured);
	if (this->stdoutCaptured) {
	captureStdout();

!Line: 268 - warning: std::move of the expression of the trivially-copyable type 'bool' has no effect; remove std::move() [hicpp-move-const-arg,performance-move-const-arg]

TestCPP/src/TestCPPTestCase.cpp

Lines 269 to 274 in ac88b62

	this->clogCaptured = std::move(rhs.clogCaptured);
	this->stderrCaptured = std::move(rhs.stderrCaptured);
	if (this->stdoutCaptured) {
	captureStdout();
	}

!Line: 269 - warning: std::move of the expression of the trivially-copyable type 'bool' has no effect; remove std::move() [hicpp-move-const-arg,performance-move-const-arg]

TestCPP/src/TestCPPTestCase.cpp

Lines 270 to 275 in ac88b62

	this->stderrCaptured = std::move(rhs.stderrCaptured);
	if (this->stdoutCaptured) {
	captureStdout();
	}
	if (this->clogCaptured) {

!Line: 270 - warning: std::move of the expression of the trivially-copyable type 'bool' has no effect; remove std::move() [hicpp-move-const-arg,performance-move-const-arg]

TestCPP/src/TestCPPTestCase.cpp

Lines 288 to 293 in ac88b62

	long long TestCase::getLastRuntime () const {
	return this->lastRunTime;
	}
	void TestCase::logFailure(ostream& out, string& reason) {
	out << fixed;

!Line: 288 - warning: use a trailing return type for this function [modernize-use-trailing-return-type]

TestCPP/src/TestCPPTestCase.cpp

Lines 300 to 305 in ac88b62

	<< endl;
	out << TCPPStr::REASON_ << reason << endl;
	}
	void TestCase::logTestFailure (string reason) {
	unique_ptr<ostream> logStream = nullptr;

!Line: 300 - warning: do not use 'endl' with streams; use '\n' instead [performance-avoid-endl]

TestCPP/src/TestCPPTestCase.cpp

Lines 301 to 306 in ac88b62

	out << TCPPStr::REASON_ << reason << endl;
	}
	void TestCase::logTestFailure (string reason) {
	unique_ptr<ostream> logStream = nullptr;

!Line: 301 - warning: do not use 'endl' with streams; use '\n' instead [performance-avoid-endl]

TestCPP/src/TestCPPTestCase.cpp

Lines 307 to 312 in ac88b62

	if (this->clogOriginal.get() != nullptr) {
	logStream = unique_ptr<ostream>(
	new ostream(this->clogOriginal.get().get())
	);
	}
	else {

!Line: 307 - warning: static member accessed through instance [readability-static-accessed-through-instance]

TestCPP/src/TestCPPTestCase.cpp

Lines 309 to 314 in ac88b62

	new ostream(this->clogOriginal.get().get())
	);
	}
	else {
	logStream = unique_ptr<ostream>(&clog);
	}

!Line: 309 - warning: static member accessed through instance [readability-static-accessed-through-instance]

TestCPP/src/TestCPPTestCase.cpp

Lines 318 to 323 in ac88b62

	if (this->clogOriginal.get() != nullptr) {
	logStream->flush();
	// If someone is looking for something in the message,
	// and it's captured, make sure it's there.
	logFailure(clog, reason);

!Line: 318 - warning: static member accessed through instance [readability-static-accessed-through-instance]

TestCPP/src/TestCPPTestCase.cpp

Lines 326 to 331 in ac88b62

	logStream.release();
	logStream.reset();
	}
	void TestCase::runTest () {
	clog << TCPPStr::START_RUN << this->testName << endl;

!Line: 326 - warning: the value returned by this function should not be disregarded; neglecting it may lead to errors [bugprone-unused-return-value]

TestCPP/src/TestCPPTestCase.cpp

Lines 331 to 336 in ac88b62

	clog << TCPPStr::START_RUN << this->testName << endl;
	this->lastRunTime = duration(this->test).count();
	if (this->notifyTestPassed) {
	clog << fixed;
	clog << setprecision(TCPPNum::TIME_PRECISION);
	clog << TCPPStr::TEST << this->testName << TCPPStr::PASS

!Line: 331 - warning: do not use 'endl' with streams; use '\n' instead [performance-avoid-endl]

TestCPP/src/TestCPPTestCase.cpp

Lines 341 to 346 in ac88b62

	<< endl;
	}
	this->pass = true;
	}
	bool TestCase::go () {

!Line: 341 - warning: do not use 'endl' with streams; use '\n' instead [performance-avoid-endl]

TestCPP/src/TestCPPTestCase.cpp

Lines 346 to 351 in ac88b62

	bool TestCase::go () {
	try {
	runTest();
	return true;
	}
	catch(const char * errorMessage) {

!Line: 346 - warning: use a trailing return type for this function [modernize-use-trailing-return-type]

TestCPP/src/TestCPPTestCase.cpp

Lines 375 to 380 in ac88b62

	void TestCase::captureStdout () {
	if (TestCase::stdoutCaptureCasesConstructed ==
	TestCase::stdoutCaptureCasesDestroyed)
	{
	TestCase::stdoutCaptureCasesConstructed += 1;
	TestCase::stdoutBuffer =

!Line: 375 - warning: method 'captureStdout' can be made static [readability-convert-member-functions-to-static]

TestCPP/src/TestCPPTestCase.cpp

Lines 399 to 404 in ac88b62

	void TestCase::captureClog () {
	if (TestCase::logCaptureCasesConstructed ==
	TestCase::logCaptureCasesDestroyed)
	{
	TestCase::logCaptureCasesConstructed += 1;
	TestCase::clogBuffer =

!Line: 399 - warning: method 'captureClog' can be made static [readability-convert-member-functions-to-static]

TestCPP/src/TestCPPTestCase.cpp

Lines 423 to 428 in ac88b62

	void TestCase::captureStdErr () {
	if (TestCase::stderrCaptureCasesConstructed ==
	TestCase::stderrCaptureCasesDestroyed)
	{
	TestCase::stderrCaptureCasesConstructed += 1;
	TestCase::stderrBuffer =

!Line: 423 - warning: method 'captureStdErr' can be made static [readability-convert-member-functions-to-static]

TestCPP/src/TestCPPTestCase.cpp

Lines 461 to 466 in ac88b62

	void TestCase::clearStdoutCapture () {
	if (TestCase::stdoutBuffer.get()) {
	TestCase::stdoutBuffer.get()->str(string());
	}
	}

!Line: 461 - warning: method 'clearStdoutCapture' can be made static [readability-convert-member-functions-to-static]

TestCPP/src/TestCPPTestCase.cpp

Lines 467 to 472 in ac88b62

	void TestCase::clearLogCapture () {
	if (TestCase::clogBuffer.get()) {
	TestCase::clogBuffer.get()->str(string());
	}
	}

!Line: 467 - warning: method 'clearLogCapture' can be made static [readability-convert-member-functions-to-static]

TestCPP/src/TestCPPTestCase.cpp

Lines 473 to 478 in ac88b62

	void TestCase::clearStderrCapture () {
	if (TestCase::stderrBuffer.get()) {
	TestCase::stderrBuffer.get()->str(string());
	}
	}

!Line: 473 - warning: method 'clearStderrCapture' can be made static [readability-convert-member-functions-to-static]

TestCPP/src/TestCPPTestCase.cpp

Lines 479 to 484 in ac88b62

	bool TestCase::checkStdout (string against) {
	return checkOutput(TestCase::stdoutBuffer.get()->str(),
	against);
	}
	bool TestCase::checkLog (string against) {

!Line: 479 - warning: use a trailing return type for this function [modernize-use-trailing-return-type]

TestCPP/src/TestCPPTestCase.cpp

Lines 481 to 486 in ac88b62

	against);
	}
	bool TestCase::checkLog (string against) {
	return checkOutput(TestCase::clogBuffer.get()->str(),
	against);

!Line: 481 - warning: parameter 'against' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param]

TestCPP/src/TestCPPTestCase.cpp

Lines 484 to 489 in ac88b62

	bool TestCase::checkLog (string against) {
	return checkOutput(TestCase::clogBuffer.get()->str(),
	against);
	}
	bool TestCase::checkStderr (string against) {

!Line: 484 - warning: use a trailing return type for this function [modernize-use-trailing-return-type]

TestCPP/src/TestCPPTestCase.cpp

Lines 486 to 491 in ac88b62

	against);
	}
	bool TestCase::checkStderr (string against) {
	return checkOutput(TestCase::stderrBuffer.get()->str(),
	against);

!Line: 486 - warning: parameter 'against' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param]

TestCPP/src/TestCPPTestCase.cpp

Lines 489 to 494 in ac88b62

	bool TestCase::checkStderr (string against) {
	return checkOutput(TestCase::stderrBuffer.get()->str(),
	against);
	}
	bool TestCase::checkOutput (string source, string against)

!Line: 489 - warning: use a trailing return type for this function [modernize-use-trailing-return-type]

TestCPP/src/TestCPPTestCase.cpp

Lines 491 to 496 in ac88b62

	against);
	}
	bool TestCase::checkOutput (string source, string against)
	{
	switch (this->option) {

!Line: 491 - warning: parameter 'against' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param]

TestCPP/src/TestCPPTestCase.cpp

Lines 494 to 499 in ac88b62

	bool TestCase::checkOutput (string source, string against)
	{
	switch (this->option) {
	case EXACT:
	if (source == against) {
	return true;

!Line: 494 - warning: use a trailing return type for this function [modernize-use-trailing-return-type]

TestCPP/src/TestCPPTestCase.cpp

Lines 494 to 499 in ac88b62

	bool TestCase::checkOutput (string source, string against)
	{
	switch (this->option) {
	case EXACT:
	if (source == against) {
	return true;

!Line: 494 - warning: the parameter 'source' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]

TestCPP/src/TestCPPTestCase.cpp

Lines 494 to 499 in ac88b62

	bool TestCase::checkOutput (string source, string against)
	{
	switch (this->option) {
	case EXACT:
	if (source == against) {
	return true;

!Line: 494 - warning: the parameter 'against' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]

TestCPP/src/TestCPPTestCase.cpp

Lines 507 to 512 in ac88b62

	if (this->clogOriginal.get() != nullptr) {
	ostream tmp(this->clogOriginal.get().get());
	tmp << nomatch.str() << endl;
	tmp.flush();
	}
	else {

!Line: 507 - warning: static member accessed through instance [readability-static-accessed-through-instance]

TestCPP/src/TestCPPTestCase.cpp

Lines 508 to 513 in ac88b62

	ostream tmp(this->clogOriginal.get().get());
	tmp << nomatch.str() << endl;
	tmp.flush();
	}
	else {
	clog << nomatch.str() << endl;

!Line: 508 - warning: static member accessed through instance [readability-static-accessed-through-instance]

TestCPP/src/TestCPPTestCase.cpp

Lines 509 to 514 in ac88b62

	tmp << nomatch.str() << endl;
	tmp.flush();
	}
	else {
	clog << nomatch.str() << endl;
	}

!Line: 509 - warning: do not use 'endl' with streams; use '\n' instead [performance-avoid-endl]

TestCPP/src/TestCPPTestCase.cpp

Lines 513 to 518 in ac88b62

	clog << nomatch.str() << endl;
	}
	return false;
	}

!Line: 513 - warning: do not use 'endl' with streams; use '\n' instead [performance-avoid-endl]

TestCPP/src/TestCPPTestCase.cpp

Lines 529 to 534 in ac88b62

	if (this->clogOriginal.get() != nullptr) {
	ostream tmp(this->clogOriginal.get().get());
	tmp << nomatch.str() << endl;
	tmp.flush();
	}
	else {

!Line: 529 - warning: static member accessed through instance [readability-static-accessed-through-instance]

TestCPP/src/TestCPPTestCase.cpp

Lines 530 to 535 in ac88b62

	ostream tmp(this->clogOriginal.get().get());
	tmp << nomatch.str() << endl;
	tmp.flush();
	}
	else {
	clog << nomatch.str() << endl;

!Line: 530 - warning: static member accessed through instance [readability-static-accessed-through-instance]

TestCPP/src/TestCPPTestCase.cpp

Lines 531 to 536 in ac88b62

	tmp << nomatch.str() << endl;
	tmp.flush();
	}
	else {
	clog << nomatch.str() << endl;
	}

!Line: 531 - warning: do not use 'endl' with streams; use '\n' instead [performance-avoid-endl]

TestCPP/src/TestCPPTestCase.cpp

Lines 535 to 540 in ac88b62

	clog << nomatch.str() << endl;
	}
	return false;
	}

!Line: 535 - warning: do not use 'endl' with streams; use '\n' instead [performance-avoid-endl]

TestCPP/src/TestCPPTestCase.cpp

Lines 542 to 547 in ac88b62

	stringstream re;
	re << TCPPStr::UNK_CMP_OPT << this->option;
	throw TestCPPException(re.str());
	}
	}
	}

!Line: 542 - warning: variable name 're' is too short, expected at least 3 characters [readability-identifier-length]

[codecov]

Codecov Report

Attention: Patch coverage is 81.63265% with 18 lines in your changes missing coverage. Please review.

Project coverage is 77.46%. Comparing base (6fd733e) to head (ac88b62).
Report is 12 commits behind head on main.

Files with missing lines	Patch %	Lines
src/TestCPPTestCase.cpp	86.25%	11 Missing ⚠️
src/TestCPPAssertions.cpp	0.00%	4 Missing ⚠️
src/TestCPPExceptions.cpp	0.00%	2 Missing ⚠️
src/TestCPPTestSuite.cpp	85.71%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #17      +/-   ##
==========================================
+ Coverage   77.36%   77.46%   +0.10%     
==========================================
  Files          19       19              
  Lines         561      568       +7     
  Branches       70       70              
==========================================
+ Hits          434      440       +6     
- Misses        110      111       +1     
  Partials       17       17              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.