Fix crash on invalid formattime #1317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
updating chrono sounds quite nice here, go for it! |
inkreasing
force-pushed
the
fix_invalid_formattime
branch
from
4257804 to
d138e02
Compare
elkowar
approved these changes
May 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1290, by checking for an error when formatting with chrono.
Edit: Also updates chrono to use the write_to API.
Additional Notes
If you would like i could also update chrono, which would allow to use the write_to method instead of the rust write! macro. This would probably be faster and it would be more obvious why there could be an error. This also would remove the need to importfmt::WriteMaybe this could be made into a function, but because the Chrono time objects are generic with different types of time this isn't obvious how to do, so i just didn't.
Checklist
Please make sure you can check all the boxes that apply to this PR.
cargo fmtto automatically format all code before committing