Update --duration when opening an existing window to get rid of the flickering#1326
Open
Elvyria wants to merge 2 commits into
Open
Update --duration when opening an existing window to get rid of the flickering#1326Elvyria wants to merge 2 commits into
--duration when opening an existing window to get rid of the flickering#1326Elvyria wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is an alternative rewrite of #1120 that removes timer if no duration was provided per #1120 (comment) and simplifies the code by utilizing CancellationToken from
tokio-utils, since the package is already here anyways.select!macro was used withoutbiased, so no more RNG overhead.Stringclone.tokio-utilversion from0.7.11to0.7.15for run_until_cancelled_owned.Additional Notes
Fixes #892
Closes #1120
Checklist
docs/content/maindirectory has been adjusted to reflect my changes.cargo fmtto automatically format all code before committing