fix: Warn on unknown egg config keys and skip deploy when no targets #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fepfitra
changed the title
fepfitra
changed the title
Owner
|
Good idea! Could you rebase your changes onto main, so I can merge this? |
Owner
|
Instead of merging, could you do a rebase? |
fepfitra
force-pushed
the
fix/targets
branch
from
716aca2 to
7146236
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typos or missing
targetscould leave an egg with an empty deployment mapping while the sync logic still logged "Successfully deployed" #59 . This change prevents that confusing message while keeping config parsing forgiving.