fix regex #15
Merged
fix regex #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks okay to me as long as we are sure we don't want a hyphen in any part of the identifier. Do you know if AppCenter or Flathub source code has a similar regex they validate against? If there is, we could use that as a reference. |
Contributor
|
Flatpak docs has some links and examples of bad IDs. Might be an opportunity to write some tests? https://docs.flatpak.org/en/latest/conventions.html#application-ids |
alainm23
requested review from
a team
and removed request for
a team,
danirabbit,
dar5hak,
lenemter and
ryonakano
danirabbit
approved these changes
Oct 17, 2024
Contributor
danirabbit
left a comment
danirabbit
left a comment
There was a problem hiding this comment.
Is an improvement, but I think I'd still like to see tests in the future to make sure we're covering all the cases correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #14
