Port to Gtk4 #90
Merged
Port to Gtk4 #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danirabbit
requested changes
Sep 26, 2024
Contributor
danirabbit
left a comment
danirabbit
left a comment
There was a problem hiding this comment.
Left some comments but it looks like maybe this isn't actually ready for review? There's a lot of commented code
Contributor
Author
|
I still have some features pending, but thanks for the comments. |
Contributor
|
Ah yeah it popped up in my notifications. Maybe better to set to draft until it's ready :) |
ryonakano
reviewed
Oct 5, 2024
Member
|
Sorry, could you revert changes against the translation files themselves? These changes often make the PR bigger so we should update the translation files later in another PR or commit |
This reverts commit 08ab9e2.
danirabbit
reviewed
Oct 9, 2024
ryonakano
reviewed
Oct 18, 2024
Co-authored-by: Ryo Nakano <[email protected]>
ryonakano
reviewed
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #80