Skip to content

Conversation

@jeremypw
Copy link
Contributor

@jeremypw jeremypw commented Nov 12, 2025

Fixes #5

WITH PRIVACY OFF

Screenshot from 2025-11-13 17 22 51

WITH PRIVACY ON

Screenshot from 2025-11-13 17 19 18

WITH SWITCH OFF

Screenshot from 2025-11-13 17 27 33

Note that with the switch off, the clipboard is no longer monitored but the existing ones remain. This is so that "favorite" items can be inserted and then not be moved/pushed out by later ones which are not needed. It is intended that a "Clear" button will be added in a later PR.

@jeremypw
Copy link
Contributor Author

@teamcons I'd appreciate your comments on this PR when you have time. I am not sure what the process is for developing this project now. I don't have permission to submit a PR directly here so I have submitted from a fork. I someone following this project for new review requests. I am following it now but cannot merge a PR.

@teamcons
Copy link
Member

there is no process nor plan atm. I can merge PRs if needed but dont have the rights to bestow them to you

i feel it is awkward to follow a setting for recent files for this.... and cant really decipher whether it stops the thingy observing clipboard content
answering on the issue

@jeremypw
Copy link
Contributor Author

It has already been implemented in Files and elsewhere that no evidence of user activity is retained when the Privacy/History setting is on. The fact that that setting is not prominent in the desktop UI is another matter.

At the moment I have it so that the clipboard is always cleared but maybe it should only be cleared if the "Clear History" button is pressed - however I am not sure that is possible for a non-core app as there isn't a setting key to bind to.

@teamcons
Copy link
Member

Unless this is added as official indicator one day and we can discuss how to integrate it with the system, i still kinda feel it would be best to do like the bluetooth indicator, and have a top switch controlling indicator behaviour (so a bool key for "continue monitoring clipboard" or something)

it is consistent with bluetooth indicator, allows very quick control what user want to do, and if they didnt want the indicator at all they wouldnt have installed it

@jeremypw
Copy link
Contributor Author

Working on it ...

 * Add Switch to HistoryWidget
 * Add "active" setting key
 * Change icon when inactive
 * Connect to owner-changed signal
 * Show different widget when Privacy is on and inactivate switch
@jeremypw jeremypw force-pushed the honor-privacy-setting branch from 363fe58 to a56b552 Compare November 13, 2025 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clipboard indicator should honor privacy settings

2 participants