-
Notifications
You must be signed in to change notification settings - Fork 1
Bind visibility to privacy setting #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@teamcons I'd appreciate your comments on this PR when you have time. I am not sure what the process is for developing this project now. I don't have permission to submit a PR directly here so I have submitted from a fork. I someone following this project for new review requests. I am following it now but cannot merge a PR. |
|
there is no process nor plan atm. I can merge PRs if needed but dont have the rights to bestow them to you i feel it is awkward to follow a setting for recent files for this.... and cant really decipher whether it stops the thingy observing clipboard content |
|
It has already been implemented in Files and elsewhere that no evidence of user activity is retained when the Privacy/History setting is on. The fact that that setting is not prominent in the desktop UI is another matter. At the moment I have it so that the clipboard is always cleared but maybe it should only be cleared if the "Clear History" button is pressed - however I am not sure that is possible for a non-core app as there isn't a setting key to bind to. |
|
Unless this is added as official indicator one day and we can discuss how to integrate it with the system, i still kinda feel it would be best to do like the bluetooth indicator, and have a top switch controlling indicator behaviour (so a bool key for "continue monitoring clipboard" or something) it is consistent with bluetooth indicator, allows very quick control what user want to do, and if they didnt want the indicator at all they wouldnt have installed it |
|
Working on it ... |
363fe58 to
a56b552
Compare
Fixes #5
WITH PRIVACY OFF
WITH PRIVACY ON
WITH SWITCH OFF
Note that with the switch off, the clipboard is no longer monitored but the existing ones remain. This is so that "favorite" items can be inserted and then not be moved/pushed out by later ones which are not needed. It is intended that a "Clear" button will be added in a later PR.