feat: add support for wasm#36
Open
HerringtonDarkholme wants to merge 1 commit intoelliottech:mainfrom
Open
Conversation
Collaborator
|
@Bvvvp009 could you take a look at this please? |
Collaborator
|
I think your changes make sense @HerringtonDarkholme |
lavrric
pushed a commit
that referenced
this pull request
Mar 12, 2026
* add support for wasm * feat: complete WASM support to match CGO/sharedlib implementation - Add global chainId variable and use it in messageToSign for L2TransferTxInfo - Add encoding/hex import for memo hex decoding - Update SignTransfer: add argument validation, complete memo hex encoding support - Fix SignCancelOrder: use safeInt16 for MarketIndex type safety - Ensure all MarketIndex uses int16 (not uint8) to support spot markets (2048+) - Match sharedlib implementation exactly for full WASM parity This completes PR #36 by adding the remaining changes needed for full WASM support that matches the CGO/sharedlib implementation. * fix: complete WASM type fixes to match CGO exactly - Add safeUint64() and safeUint16() helper functions for type-safe extraction - Fix SignCreatePublicPool: minOperatorShareRate now uses uint16 (was int64) - Fix SignUpdatePublicPool: publicPoolIndex now uses int64 (was uint8) and minOperatorShareRate uses uint16 (was int64) - Optimize SignWithdraw: use direct uint64 extraction instead of int64 conversion All type conversions now match CGO/sharedlib implementation exactly. All 19 exported functions verified and correct. * fix nonce handling * Revert "fix nonce handling" This reverts commit 0d49812. --------- Co-authored-by: HerringtonDarkholme <2883231+HerringtonDarkholme@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi lighter team, this pull request enables wasm build for host like JavaScript to use.
The change is mainly
Other than that, the wasm build also introduces a new global variable
chainIdthat reflects the same architecture of sharelib version.That means the wasm user will have to use the lib in a single-threaded way, which is quite common in JS world