fix(cfr): fall back to Call when preflop chart prescribes raise but cap is reached#271
Merged
elliottneilclark merged 1 commit intomasterfrom Apr 16, 2026
Merged
Conversation
…ap is reached When `max_raises_per_round` (default 3) was reached during preflop, `PreflopChartActionGenerator::convert_preflop_action` still emitted a `Bet(three_bet_amount)` for chart entries marked Raise/ThreeBet/FourBet. The downstream `validate_actions` pipeline (introduced in 598ebb5) then stripped this bet via `filter_raises_when_capped`, leaving an empty action set. `ActionPicker::pick_action` subsequently panicked with "cannot sample empty range" inside `rng.random_range(0..0)`. The fix checks `game_state.is_raise_capped()` in `convert_preflop_action` and returns `AgentAction::Call` for any raise-type chart action when the cap is reached. This preserves the chart's intent — the hand is playable — while respecting the raise limit so the agent calls to see the flop instead of producing an action that gets filtered into an empty set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
max_raises_per_round(default 3) was reached during preflop,PreflopChartActionGenerator::convert_preflop_actionstill emitted aBet(three_bet_amount)for chart entries marked Raise/ThreeBet/FourBet.The downstream
validate_actionspipeline (introduced in 598ebb5) thenstripped this bet via
filter_raises_when_capped, leaving an emptyaction set.
ActionPicker::pick_actionsubsequently panicked with"cannot sample empty range" inside
rng.random_range(0..0).The fix checks
game_state.is_raise_capped()inconvert_preflop_actionand returns
AgentAction::Callfor any raise-type chart action when thecap is reached. This preserves the chart's intent — the hand is playable
— while respecting the raise limit so the agent calls to see the flop
instead of producing an action that gets filtered into an empty set.