Skip to content

Add genre to song #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

sorianog
Copy link

@sorianog sorianog commented Aug 4, 2018

@Byorun This is a work in progress PR. I would like your comments on what should be added/changed. I am new to the language, so any pointers are welcome!

Attempts to partially address Issue #12

@Byorun
Copy link
Contributor

Byorun commented Aug 5, 2018

that is a good start, but i would add the genre to the song table since it will always be the same even if the author updates the song.

@sorianog
Copy link
Author

sorianog commented Aug 5, 2018

Sounds good. Made the change.

@Byorun
Copy link
Contributor

Byorun commented Aug 6, 2018

now you need a list of genres and a way to select one in the upload/edit process

@sorianog
Copy link
Author

sorianog commented Aug 6, 2018 via email

@Byorun
Copy link
Contributor

Byorun commented Aug 6, 2018

I will be easier to search if the list is fix (maybe stored in the database)

@sorianog
Copy link
Author

sorianog commented Aug 8, 2018

Trying to research the best genres to include and found this article (data from 2015): https://www.digitalmusicnews.com/2016/04/07/most-popular-music-genres-america/
Saw a 2017 report with the same genres in that article (data from the same company, Nielsen Music). That would be 11 genres to start off with.

@Byorun
Copy link
Contributor

Byorun commented Aug 8, 2018

@sorianog Someone from Discord mention the LastFM API

@razzeee
Copy link
Contributor

razzeee commented Sep 9, 2018

Unfortunately musicbrainz doesn't have genres yet https://wiki.musicbrainz.org/Genre
But if we want to go the tag route, musicbrainz does have those

But theaudiodb does have a genre but doesn't seem to have an endpoint for that https://www.theaudiodb.com/api_guide.php

@sorianog
Copy link
Author

sorianog commented Sep 9, 2018

@razzeee Feel free to pick up this PR if you want. I can't get php to work on my Windows machine. Might have to go to a VM route...

@razzeee
Copy link
Contributor

razzeee commented Sep 9, 2018

@sorianog sounds like #19 might help you?

anyway, haven't done php/laravel for two years, not sure I want to go back

@razzeee
Copy link
Contributor

razzeee commented Sep 11, 2018

Here's how I would do the storage. razzeee@a4a379f

It's untested so far, but should work in theory. But has no frontend and no api integration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants