-
Notifications
You must be signed in to change notification settings - Fork 18
Add genre to song #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
that is a good start, but i would add the genre to the song table since it will always be the same even if the author updates the song. |
Sounds good. Made the change. |
now you need a list of genres and a way to select one in the upload/edit process |
Do we want a list of genre's or have the user fill it in themselves?
…On Mon, Aug 6, 2018, 12:17 PM Byorun ***@***.***> wrote:
now you need a list of genres and a way to select one in the upload/edit
process
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#13 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AMpbjxj784j-L0rdVX_51zCa1SkCmCkwks5uOGwxgaJpZM4VvKFR>
.
|
I will be easier to search if the list is fix (maybe stored in the database) |
Trying to research the best genres to include and found this article (data from 2015): https://www.digitalmusicnews.com/2016/04/07/most-popular-music-genres-america/ |
@sorianog Someone from Discord mention the LastFM API |
Unfortunately musicbrainz doesn't have genres yet https://wiki.musicbrainz.org/Genre But theaudiodb does have a genre but doesn't seem to have an endpoint for that https://www.theaudiodb.com/api_guide.php |
@razzeee Feel free to pick up this PR if you want. I can't get php to work on my Windows machine. Might have to go to a VM route... |
Here's how I would do the storage. razzeee@a4a379f It's untested so far, but should work in theory. But has no frontend and no api integration. |
@Byorun This is a work in progress PR. I would like your comments on what should be added/changed. I am new to the language, so any pointers are welcome!
Attempts to partially address Issue #12