ui: keep every full-frame screen on the alternate buffer - #119
Merged
Conversation
…, rename placeholder to cloud agent
Only a live chat runs on the primary buffer now. The new-session composer and the loading placeholder painted full-height frames onto the primary buffer, pushing stale copies of themselves into scrollback on every repaint. useAltScreen also reports when the buffer hop has settled, and the chat mounts only after the terminal is back on the primary buffer, so its Static transcript rows are never printed onto (and destroyed with) the alt screen.
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed d1db75b in 13 minutes, 56 seconds.
- Reviewed
2commits with169lines of code in2files - Ran
1review agent producing0comments where0were posted - This pipeline runs no gatekeeper, so findings are posted as written.
- View full details on ellipsis.dev
This review was created by 
@ellipsis in this pull request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Moves all full-frame screens (new-session composer, loading placeholder, session picker) to the alternate buffer, keeping only the live chat on the primary buffer to prevent stale copies from accumulating in scrollback on every repaint.
useAltScreennow returns a boolean indicating when the buffer hop is complete (wasvoid), allowing components to wait until it's safe to render into the terminal's real scrollback.<Static>transcript rows are never printed while the alt screen is active and destroyed with it.wrap-ansito trim whitespace at wrap points.This description was created by
for d1db75b. It will automatically update as commits are pushed.