Fix not only looking at pattern when trying to find prefix for case#1480
Merged
razzeee merged 3 commits intoelm-tooling:mainfrom Mar 9, 2026
Merged
Fix not only looking at pattern when trying to find prefix for case#1480razzeee merged 3 commits intoelm-tooling:mainfrom
razzeee merged 3 commits intoelm-tooling:mainfrom
Conversation
…entally picking up a prefix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation for adding missing case branches would look for a prefix not only from the pattern but also from the branch expression. This would make it so a prefix was erroneously added when the branch also contained any
upper_case_identifierssuch as String.length, or in the test case added, Html.text. The updated version makes sure we restrict the lookup to only look at the pattern itself.Also improves the test case names to clarify what "needed" in the case of a prefix means.