Have Elm.Project.encode order the dependencies the same way the compiler does#19
Open
jfmengels wants to merge 1 commit intoelm:masterfrom
Open
Have Elm.Project.encode order the dependencies the same way the compiler does#19jfmengels wants to merge 1 commit intoelm:masterfrom
jfmengels wants to merge 1 commit intoelm:masterfrom
Conversation
…ler does The Elm.Project.encode function previously did an alphabetical sort, which means that packages like "elm-community/*" would show up before "elm/*". The compiler, elm-json and elm-test-rs all on the other hand seem to sort by author then by package name, so "elm/*" shows up before "elm-community/*". This change makes it so that the author name is compared first, then the package name, to act like the compiler and the other tools.
rupertlssmith
pushed a commit
to elm-janitor/project-metadata-utils
that referenced
this pull request
Feb 17, 2023
Have Elm.Project.encode order the dependencies the same way the compiler does The Elm.Project.encode function previously did an alphabetical sort, which means that packages like "elm-community/*" would show up before "elm/*". The compiler, elm-json and elm-test-rs all on the other hand seem to sort by author then by package name, so "elm/*" shows up before "elm-community/*". This change makes it so that the author name is compared first, then the package name, to act like the compiler and the other tools.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Elm.Project.encode function previously did an alphabetical sort, which means that packages like "elm-community/" would show up before "elm/". The compiler, elm-json and elm-test-rs all on the other hand seem to sort by author then by package name, so "elm/" shows up before "elm-community/".
This change makes it so that the author name is compared first, then the package name, to act like the compiler and the other tools.
I noticed this because
elm-reviewnow allows for automatic fixes forelm.jsonfiles where we useElm.Project.encodeto write the contents of the file. Doing so would change the order of the dependencies in a way that creates confusion to the user ("oh why did it remove this dependency? Oh it just moved it alright")