Fix diffing for namespaced attributes (Fixes #62)#159
Open
anka-213 wants to merge 1 commit intoelm:masterfrom
Open
Fix diffing for namespaced attributes (Fixes #62)#159anka-213 wants to merge 1 commit intoelm:masterfrom
anka-213 wants to merge 1 commit intoelm:masterfrom
Conversation
ahankinson
added a commit
to elm-janitor/virtual-dom
that referenced
this pull request
Nov 20, 2025
fixes elm#187 fixes elm#182 fixes elm/html#44 fixes elm/browser#121 fixes elm/browser#66 fixes elm#62 fixes elm#127 fixes elm#147 fixes elm#159 fixes elm#105 fixes elm#162 fixes elm#171 fixes elm#175 fixes elm#178 fixes elm#180 fixes elm#183 fixes elm#189 fixes elm#166 fixes elm/html#160 fixes elm/html#177 fixes elm/compiler#2069
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The value of a namespaced attribute is an object on the form
so we cannot use reference equality to compare them.
This patch instead uses reference equality on namespace and value separately.
See issue #62